1773325 - PiP Subtitles Support for Washington Post

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[Edward Brace]

Current Behavior

• Navigate to https://www.washingtonpost.com/
• Play a video
• Enable subtitles in player
• Open video in PiP player

Actual Results:
No subtitles displayed in PiP window

Expected results:
Subtitles are displayed in PiP window

Comment 1

[kpatenio [PTO Dec 18 - Jan 4]]

This can be potentially resolved once Bug 1754549 and its follow up Bug 1766705 are implemented. This is due to Washington Post using WebVTT (which we support), but having its mode set to "hidden". We can only show captions for WebVTT cues with mode set to "showing". We'd need to add Washington Post to a list of sites to override via remote settings.

Unfortunately, I had not had a chance to review the patch for Bug 1754549 yet. But seeing more requests for subtitles support on a site like this is giving me more reason to revisit that patch sooner.

Comment 2

[Edward Brace]

Attachment: Bug 1773325 - Added PiP Subtitles Support for Washington Post r=kpatenio

Comment 3

[Edward Brace]

(In reply to kpatenio from comment #1)

This can be potentially resolved once Bug 1754549 and its follow up Bug 1766705 are implemented. This is due to Washington Post using WebVTT (which we support), but having its mode set to "hidden". We can only show captions for WebVTT cues with mode set to "showing". We'd need to add Washington Post to a list of sites to override via remote settings.

Unfortunately, I had not had a chance to review the patch for Bug 1754549 yet. But seeing more requests for subtitles support on a site like this is giving me more reason to revisit that patch sooner.

I submitted my fix just in case. But obviously a more generally applicable solution is better.

Comment 4

[Edward Brace]

Attachment: Bug 1773325 - Abstracted away HTML manipulation r=#pip-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ff5297d2d57
Added PiP Subtitles Support for Washington Post r=kpatenio

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3ff5297d2d57