Closed Bug 1754595 Opened 10 months ago Closed 9 months ago

Don't show blocked quick suggest suggestions even when they match the user's search string

Categories

(Firefox :: Address Bar, task, P1)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- verified

People

(Reporter: adw, Assigned: daisuke)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1754595: Don't show blocked suggestions.
48 bytes, text/x-phabricator-request
Details | Review

Blocked quick suggest suggestions should not be shown to the user, neither as best matches nor as usual matches. This logic should probably be implemented inside UrlbarProviderQuickSuggest because it should apply to suggestions from both remote settings and Merino. Both UrlbarQuickSuggest and Merino would still be allowed to return matching suggestions to the provider, and then the provider should check whether a fetched suggestion is blocked and if so it should not create and add a result for it.

This doesn't involve UI at all so it should be simpler than the other best-match bugs that do.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Attachment #9264332 - Attachment description: WIP: Bug 1754595: Don't show blocked suggestions. → Bug 1754595: Don't show blocked suggestions.
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea7b0729b45e
Don't show blocked suggestions. r=adw

STR for QA:

This bug is important because it should prevent blocked suggestions from showing up in new searches. Blocked suggestions should not appear as best matches or as usual Suggest suggestions. There are a variety of STR, for example:

  1. Enable Firefox Suggest
  2. Enable best match by setting browser.urlbar.bestMatch.enabled to true
  3. Type "amazon" to trigger a best match
  4. Pick the thumbs-down block button in the best match
  5. Verify the best match row disappears
  6. Clear the input and type "amazon" again
  7. Verify the Amazon suggestion does not appear. It should not appear as a best batch or a usual Suggest suggestion
  8. Type "betty" to trigger the Betty White Wikipedia best match
  9. Pick the thumbs-down block button in the best match
  10. Verify the best match row disappears
  11. Clear the input and type "betty" again
  12. Verify the Betty White Wikipedia suggestion does not appear. It should not appear as a best batch or a usual Suggest suggestion
  13. Clear the input and type "amazon" again
  14. Verify the Amazon suggestion does not appear again
  15. Restart Firefox and repeat the searches. The blocked suggestions should not appear
  16. Reset the browser.urlbar.quickSuggest.blockedDigests pref and repeat the searches. This time, the previously blocked suggestions should appear because they are no longer blocked due to clearing the pref
Flags: qe-verify+
Flags: in-testsuite+

https://hg.mozilla.org/mozilla-central/rev/ea7b0729b45e

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch

I have verified this issue on the latest Nightly 99.0a1 build (Build ID: 20220223093800) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20.

  • In order to verify this issue I have used the STR described in comment 3.
  • The results are successfully dismissed and they no longer appear (in "Top Pick" section or "Firefox Suggest section).
  • The results are re-displayed after the pref is deleted.
Status: RESOLVED → VERIFIED
status-firefox99: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.