1754682 - Subscribe to webcal:// URI from command line fails since the feed url ends with .ics

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, enhancement)

Description

[Christian Weiske]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:96.0) Gecko/20100101 Firefox/96.0

Steps to reproduce:

I wanted to subscribe to a iCal feed from command line by running
"thunderbird webcal://calendar.google.com/calendar/ical/mozilla.com_dbq84anr9i8tcnmhabatstv5co%40group.calendar.google.com/public/basic.ics"

Actual results:

When Thunderbird was already running, nothing happened at all.

When Thunderbird was not running yet, it tried to start but the main window did not appear. Some errors appeared on terminal and it exited. Output on console was:

$ thunderbird webcal://calendar.google.com/calendar/ical/mozilla.com_dbq84anr9i8tcnmhabatstv5co%40group.calendar.google.com/public/basic.ics
[calBackendLoader] Using Thunderbird's libical backend
[LDAPModuleLoader] Using LDAPDirectory.jsm
[MsgSendModuleLoader] Using MessageSend.jsm
[SmtpModuleLoader] Using SmtpService.jsm
JavaScript error: resource:///modules/MessengerContentHandler.jsm, line 494: NS_ERROR_FILE_TARGET_DOES_NOT_EXIST: Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsICommandLine.resolveFile]
JavaScript error: moz-extension://ef44ed31-97a6-418c-b084-904093efabc0/punycode/punycode.js, line 440: ReferenceError: module is not defined

Expected results:

The "add new network calendar" popup should appear, just as if I went to the calendar view and clicked "new calendar" and then "network calendar".

Both webcal:// and webcals:// schemes should be supported.

(Using webcal:// instead of http:// in links on websites makes sense, because then the browser can hand that URL to the calendaring application instead of downloading the http URL and handling the downloaded file to the calendar app.)

Comment 1

[Magnus Melin [:mkmelin]]

Ah, because the uri ends with .ics.
These two if-else clauses need to be switched around I think. https://searchfox.org/comm-central/rev/274a03b8b16264a2f0394d68693f362b05c03d22/mail/components/MessengerContentHandler.jsm#496,508

Nicolai, maybe you want to jump on this small bug.

Comment 2

[u695164]

Yep will do it.

Comment 3

[u695164]

Attachment: Bug 1754682 - Fix CLI webcals and mid import with .ics ending. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0889071b2bef
Fix CLI webcals and mid import with .ics ending. r=mkmelin

Comment 5

[u695164]

Comment on attachment 9263281 [details]
Bug 1754682 - Fix CLI webcals and mid import with .ics ending. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): Bug 352566.
User impact if declined: CLI webcals import with URI endings with .ics are crashing Thunderbird.
Testing completed (on c-c, etc.): Manual testing, CLI testing isn't supported yet. Tested an .ics file, an webcals uri with .ics and and an mid import (without .ics ending). All tests worked.
Risk to taking this patch (and alternatives if risky): I don't see any risks so far.

Comment 6

[Wayne Mery (:wsmwk)]

User impact if declined: CLI webcals import with URI endings with .ics are crashing Thunderbird.

Crashes? If so, is there a crash report?
Or hangs?

This will need to uplift to beta before landing on esr91. Or it is a very old regression so perhaps urgency, in which case it can "ride the train" to the next beta - the merge occurs in three weeks.

Comment 7

[u695164]

Comment on attachment 9263281 [details]
Bug 1754682 - Fix CLI webcals and mid import with .ics ending. r=mkmelin

Thanks wsmwk. It's a crash. It should be possible to use the GUI to import webcals with a .ics ending.
But using the CLI ends in a crash. See the bug filing description:

$ thunderbird webcal://calendar.google.com/calendar/ical/mozilla.com_dbq84anr9i8tcnmhabatstv5co%40group.calendar.google.com/public/basic.ics
[calBackendLoader] Using Thunderbird's libical backend
[LDAPModuleLoader] Using LDAPDirectory.jsm
[MsgSendModuleLoader] Using MessageSend.jsm
[SmtpModuleLoader] Using SmtpService.jsm
JavaScript error: resource:///modules/MessengerContentHandler.jsm, line 494: [...]

(see comment#5)
[Approval Request Comment]
Regression caused by (bug #): Bug 352566.
User impact if declined: CLI webcals import with URI endings with .ics are crashing Thunderbird.
Testing completed (on c-c, etc.): Manual testing, CLI testing isn't supported yet. Tested an .ics file, an webcals uri with .ics and and an mid import (without .ics ending). All tests worked.
Risk to taking this patch (and alternatives if risky): I don't see any risks so far.

Comment 8

[Magnus Melin [:mkmelin]]

To clarify, that is not what we refer to as a crash (a crash is when the whole application goes down). It's only an error in the console and non-working functionality.
But good to uplift nonetheless.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9263281 [details]
Bug 1754682 - Fix CLI webcals and mid import with .ics ending. r=mkmelin

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 98.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/e29e702ed88f

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9263281 [details]
Bug 1754682 - Fix CLI webcals and mid import with .ics ending. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 91.8.0:
https://hg.mozilla.org/releases/comm-esr91/rev/acf6f308b6e2