perma comm/mailnews/extensions/newsblog/test/browser/browser_feedDisplay.js | "rgba(0, 0, 0, 0)" == "rgb(0, 128, 0)" - got "rgba(0, 0, 0, 0)", expected "rgb(0, 128, 0)" (operator ==)
Categories
(MailNews Core :: Feed Reader, defect, P5)
Tracking
(thunderbird_esr91 fixed, thunderbird98 fixed)
People
(Reporter: intermittent-bug-filer, Assigned: darktrojan)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
rjl
:
approval-comm-beta+
|
Details | Review |
2.41 KB,
patch
|
rjl
:
approval-comm-esr91+
|
Details | Diff | Splinter Review |
Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=367369321&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cH5qYBuESxeJ4d6P-ER7VQ/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 6•3 years ago
|
||
This is related to process switching. When we load a feed message as a web page, we first load the message in a parent process browser to get the header display working, then immediately switch to a child process browser to display the page. Somehow the sandbox flags are copied across and applied to the web page. Here we apply flags to the feed document but those same flags get applied to the web document (even if you remove the early return for lack of a docShell). If we wait for about:blank to load after switching browser remoteness, this problem doesn't occur, but that's not a simple thing to do.
Assignee | ||
Comment 7•3 years ago
|
||
Although, if we load about:blank in the parent process before switching remoteness, this test passes!
Assignee | ||
Comment 8•3 years ago
|
||
This fixes the problem but it doesn't fix the wider problem, which having to load the message (to display the headers) only to immediately discard it and load the webpage.
Updated•3 years ago
|
Comment hidden (Intermittent Failures Robot) |
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/28c9f2841dcf
Load about:blank before switching from feed message to feed web page. r=mkmelin
Comment 11•3 years ago
|
||
Comment on attachment 9265657 [details]
Bug 1754785 - Load about:blank before switching from feed message to feed web page. r=mkmelin
[Approval Request Comment]
Regression caused by (bug #): 1744352
Per bug 1754672 comment 16 this bug is also caused by bug 1744352 which was uplifted to m-esr91.
Comment 12•3 years ago
|
||
Comment on attachment 9265657 [details]
Bug 1754785 - Load about:blank before switching from feed message to feed web page. r=mkmelin
[Triage Comment]
Caused by bug 1744352 which was uplifted to m-beta. This needs to go into 98.0b3 for testing as it is also needed for 91.7.0.
Comment 13•3 years ago
|
||
bugherder uplift |
Thunderbird 98.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a23f836bee6f
Comment 14•3 years ago
|
||
I'm not sure what to do for esr91. The patch doesn't apply. newsblogOverlay.js on c-esr91 is using getBrowser() rather than getMessagePaneBrowser(). That change is from bug 1751120.
Comment 15•3 years ago
|
||
After talking to Magnus, I've updated the patch for c-esr91.
Updated•3 years ago
|
Comment 16•3 years ago
|
||
Comment on attachment 9265932 [details] [diff] [review]
Bug_1754785_esr91.patch
[Triage Comment]
Needed due to uplift of bug 1744352 to m-esr91.
Comment 17•3 years ago
|
||
bugherder uplift |
Thunderbird 91.7.0:
https://hg.mozilla.org/releases/comm-esr91/rev/7f0a2fefffe2
Comment 18•3 years ago
|
||
After talking to Magnus, I've been able to update the patch for c-esr91.
Description
•