Closed Bug 1754785 Opened 3 years ago Closed 3 years ago

perma comm/mailnews/extensions/newsblog/test/browser/browser_feedDisplay.js | "rgba(0, 0, 0, 0)" == "rgb(0, 128, 0)" - got "rgba(0, 0, 0, 0)", expected "rgb(0, 128, 0)" (operator ==)

Categories

(MailNews Core :: Feed Reader, defect, P5)

Tracking

(thunderbird_esr91 fixed, thunderbird98 fixed)

RESOLVED FIXED
99 Branch
Tracking Status
thunderbird_esr91 --- fixed
thunderbird98 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: darktrojan)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Potentially related to bug 1754672

See Also: → 1754672

This is related to process switching. When we load a feed message as a web page, we first load the message in a parent process browser to get the header display working, then immediately switch to a child process browser to display the page. Somehow the sandbox flags are copied across and applied to the web page. Here we apply flags to the feed document but those same flags get applied to the web document (even if you remove the early return for lack of a docShell). If we wait for about:blank to load after switching browser remoteness, this problem doesn't occur, but that's not a simple thing to do.

Although, if we load about:blank in the parent process before switching remoteness, this test passes!

This fixes the problem but it doesn't fix the wider problem, which having to load the message (to display the headers) only to immediately discard it and load the webpage.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Target Milestone: --- → 99 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/28c9f2841dcf
Load about:blank before switching from feed message to feed web page. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9265657 [details]
Bug 1754785 - Load about:blank before switching from feed message to feed web page. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1744352
Per bug 1754672 comment 16 this bug is also caused by bug 1744352 which was uplifted to m-esr91.

Attachment #9265657 - Flags: approval-comm-esr91?

Comment on attachment 9265657 [details]
Bug 1754785 - Load about:blank before switching from feed message to feed web page. r=mkmelin

[Triage Comment]
Caused by bug 1744352 which was uplifted to m-beta. This needs to go into 98.0b3 for testing as it is also needed for 91.7.0.

Attachment #9265657 - Flags: approval-comm-beta+

I'm not sure what to do for esr91. The patch doesn't apply. newsblogOverlay.js on c-esr91 is using getBrowser() rather than getMessagePaneBrowser(). That change is from bug 1751120.

Flags: needinfo?(mkmelin+mozilla)

After talking to Magnus, I've updated the patch for c-esr91.

Flags: needinfo?(mkmelin+mozilla)
Attachment #9265657 - Flags: approval-comm-esr91?

Comment on attachment 9265932 [details] [diff] [review]
Bug_1754785_esr91.patch

[Triage Comment]
Needed due to uplift of bug 1744352 to m-esr91.

Attachment #9265932 - Flags: approval-comm-esr91+

After talking to Magnus, I've been able to update the patch for c-esr91.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: