Useless includes in js/
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: serge.guelton, Assigned: serge.guelton)
References
(Blocks 3 open bugs)
Details
Attachments
(1 file, 1 obsolete file)
Steps to reproduce:
I ran include-what-you-use[0] on the js/ codebase and realized that some includes where not necessary
[0] https://include-what-you-use.org/
Actual results:
This makes clang process more source code than strictly necessary.
I've started investigating and plan to do the associated cleanup.
Expected results:
Same result with less preprocessed code :-)
Assignee | ||
Comment 1•3 years ago
|
||
Comment 2•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Comment 3•3 years ago
|
||
The patch seems worth submitting for review: In this case, you could tag Iain Ireland for review.
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Backed out for causing bustage on WeakMapObject.cpp
- backout: https://hg.mozilla.org/integration/autoland/rev/4c57ee89730d9d8e2ea0281ece7a65c9bc6bbb76
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=62bd03bc3763665d13eb575e147c116662d56ffe
- failure log: https://treeherder.mozilla.org/logviewer?job_id=372262168&repo=autoland&lineNumber=24670
[task 2022-03-24T21:54:07.551Z] 21:54:07 INFO - In file included from Unified_cpp_js_src3.cpp:11:
[task 2022-03-24T21:54:07.551Z] 21:54:07 ERROR - /builds/worker/checkouts/gecko/js/src/builtin/WeakMapObject.cpp:238:8: error: use of undeclared identifier 'ThrowIfNotConstructing'
[task 2022-03-24T21:54:07.552Z] 21:54:07 INFO - if (!ThrowIfNotConstructing(cx, args, "WeakMap")) {
[task 2022-03-24T21:54:07.552Z] 21:54:07 INFO - ^
[task 2022-03-24T21:54:07.552Z] 21:54:07 INFO - 1 error generated.
[task 2022-03-24T21:54:07.552Z] 21:54:07 ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: Unified_cpp_js_src3.o] Error 1
[task 2022-03-24T21:54:07.552Z] 21:54:07 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/js/src'
[task 2022-03-24T21:54:07.553Z] 21:54:07 INFO - gmake[4]: *** Waiting for unfinished jobs....
Assignee | ||
Comment 7•3 years ago
|
||
I've updated the PR, current state looks ok to me - see https://treeherder.mozilla.org/#/jobs?repo=try&revision=210eb118106314233c6e1bb414247f575864657c
Impact on preprocessor output: -176866 lines
Comment 9•3 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•