903843 - (iwyu) Use include-what-you-use (iwyu)

Status: NEW

(Developer Infrastructure :: Source Code Analysis, enhancement, P3)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: fix_includes.py

To set up iwyu, I found <http://code.google.com/p/include-what-you-use/wiki/InstructionsForUsers> clear enough. (I used "Building in-tree".)

I made a few changes to the fix_includes.py script; the result is attached.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Would it be a good idea to get a tool like this integrated into our clang plugin to vocally complain when you include things you don't use? I'm worried that it won't work nicely with our unified builds.

Comment 4

[Nick Alexander :nalexander [he/him]]

Periodically, individuals run IWYU against the tree. For example, I see that :botond did this in tickets like https://bugzilla.mozilla.org/show_bug.cgi?id=1605466 and :sg did a large pass recently in tickets rooted at https://bugzilla.mozilla.org/show_bug.cgi?id=1676346.

In the years since this ticket was filed, it's become much easier to write and run custom linters and we've invested heavily into clang-based tooling. Perhaps the time is now for running IWYU in automation...

My specific use case is that I'd like to be able to visualize what includes a certain file (in my case, xptdata.h) without configuring IWYU myself.

Comment 5

[Marco Castelluccio [:marco]]

:nalexander, there is bug 1682477 about integrating IWYU in the review bot.