1754977 - 0.17 - 0.12% installer size / installer size + 1 more (OSX) regression on Mon February 7 2022

Status: RESOLVED FIXED

(Core :: DOM: Streams, defect, P2)

Description

[Andra Esanu (needinfo me)]

Perfherder has detected a build_metrics performance regression from push 455cd92099875554169ae0b62781799d5d05b03c. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.17%	installer size	osx-aarch64-shippable	aarch64 nightly	80,888,271.17 -> 81,023,371.75
0.14%	installer size	osx-aarch64-shippable	aarch64 nightly	80,890,170.92 -> 81,003,839.75
0.12%	installer size	osx-shippable	instrumented	117,886,092.88 -> 118,032,775.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Andra Esanu (needinfo me)]

This has been backedout in https://bugzilla.mozilla.org/show_bug.cgi?id=1752206#c4

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

(And it's also been re-landed, so we'll likely see this one come back)

Plan: As landed, we're currently building the JS streams implementation. We need to stop doing that as it's just dead code when shipped in a DOM Streams enabled build.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1752206

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1754977 - Don't build JS Streams when MOZ_DOM_STREAMS is enabled r?jandem

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9567b8e878da
Don't build JS Streams when MOZ_DOM_STREAMS is enabled r=jandem

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9567b8e878da