1755229 - MaybeQueueCacheUpdateForStyleChanges gets null frame for reconstructed frames

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

While working on caching the display style (bug 1743968), I discovered that when MaybeQueueCacheUpdateForStyleChanges gets called for a reconstructed frame, GetFrame() returns null. This means we can't check for style changes and thus we don't send a cache update.

My guess is that when DidSetComputedStyle is called for a reconstructed frame, the frame isn't fully constructed, so nsIContent::GetPrimaryFrame doesn't know about it yet. We can fix this by calling MaybeQueueCacheUpdateForStyleChanges from PruneOrInsertSubtree instead.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1755229: Call MaybeQueueCacheUpdateForStyleChanges from PruneOrInsertSubtree to handle reconstructed frames.

We already call MaybeQueueCacheUpdateForStyleChanges from DidSetComputedStyle for reconstructed frames.
However, at that point, nsIContent::GetPrimaryFrame (and thus LocalAccessible::GetFrame) returns null, which means we're unable to check for style changes.
Instead, we now handle style changes for reconstructed frames in PruneOrInsertSubtree, at which point the frame is definitely available.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f307defee29
Call MaybeQueueCacheUpdateForStyleChanges from PruneOrInsertSubtree to handle reconstructed frames. r=morgan,emilio

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6f307defee29