Closed Bug 1744573 Opened 4 years ago Closed 3 years ago

Apply single-level transforms to cached bounds

Categories

(Core :: Disability Access APIs, defect, P2)

defect

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: morgan, Assigned: morgan)

References

Details

Attachments

(4 files)

We should move transform calculation into RemoteAccessibleBase::Bounds so we have control over document transforms and can fix them down the line.

This bug focuses on (a) removing transforms from cached bounds, (b) caching the transform matrix and (c) applying single-level transforms.

data:text/html,<div style="background:green; height:100px; width:100px; transform:rotate(30deg);">hello world</div>

Attachment #9253941 - Attachment description: WIP: Bug 1744573: Cache transform matrix, apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay → WIP: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay
Attachment #9254186 - Attachment description: WIP: Bug 1744573: Cache the transform matrix r?eeejay,Jamie → Bug 1744573: Cache the transform matrix r?eeejay,Jamie
Attachment #9253941 - Attachment description: WIP: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay → Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay
Severity: -- → S3
Priority: -- → P2
Attachment #9254186 - Attachment description: Bug 1744573: Cache the transform matrix r?eeejay,Jamie → WIP: Bug 1744573: Cache the transform matrix r?eeejay,Jamie
Attachment #9253941 - Attachment description: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay → WIP: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay
Attachment #9254186 - Attachment description: WIP: Bug 1744573: Cache the transform matrix r?eeejay,Jamie → Bug 1744573: Cache the transform matrix r?eeejay,Jamie
Attachment #9253941 - Attachment description: WIP: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay → Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay
Attachment #9259854 - Attachment description: WIP: Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio → Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio
Attachment #9259854 - Attachment description: Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio → WIP: Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio
Attachment #9254186 - Attachment description: Bug 1744573: Cache the transform matrix r?eeejay,Jamie → WIP: Bug 1744573: Cache the transform matrix r?eeejay,Jamie
Attachment #9253941 - Attachment description: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay → WIP: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay
Attachment #9260228 - Attachment description: WIP: Bug 1744573: Add infrastrucutre on DocAccessible to queue cache updates r?Jamie,eeejay → Bug 1744573: Add infrastrucutre on DocAccessible to queue cache updates r?Jamie,eeejay
Attachment #9259854 - Attachment description: WIP: Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio → Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio
Attachment #9254186 - Attachment description: WIP: Bug 1744573: Cache the transform matrix r?eeejay,Jamie → Bug 1744573: Cache the transform matrix r?eeejay,Jamie
Attachment #9253941 - Attachment description: WIP: Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay → Bug 1744573: Apply single-level transforms in RemoteAccessibleBase::Bounds r?Jamie,eeejay
Attachment #9260228 - Attachment description: Bug 1744573: Add infrastrucutre on DocAccessible to queue cache updates r?Jamie,eeejay → Bug 1744573: Add infrastructure on DocAccessible to queue cache updates r?Jamie,eeejay
Pushed by mreschenberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9563d86fec9d Add infrastructure on DocAccessible to queue cache updates r=Jamie
Attachment #9259854 - Attachment description: Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio → WIP: Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio
Keywords: leave-open
Attachment #9259854 - Attachment description: WIP: Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio → Bug 1744573: Maintain a reference to old ComputedStyle struct on LocalAccessibles r?Jamie,emilio
Pushed by mreschenberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91062973874c Maintain a reference to old ComputedStyle struct on LocalAccessibles r=Jamie,emilio
Blocks: 1755229
Pushed by mreschenberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f0c0617055db Cache the transform matrix r=eeejay,Jamie https://hg.mozilla.org/integration/autoland/rev/409c92ad6bb7 Apply single-level transforms in RemoteAccessibleBase::Bounds r=eeejay,Jamie,emilio
Keywords: leave-open
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
Blocks: 1765944
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: