1755305 - Visual Studio clean and build targets fail

Status: RESOLVED FIXED

(Developer Infrastructure :: Developer Environment Integration, task)

Description

[Max Vollmer (they/them)]

The generated msvc/mach.bat that is a target of generated Visual Studio projects, calls mach and then keeps exit code of mach. If mach prints a warning, the exit code is 2. Visual Studio however considers any non-zero exit code in a batch file an error condition, and marks the build as failed (even though it succeeded).

The mach.bat gets generated by python/mozbuild/mozbuild/backend/visualstudio.py

Ideally we just add a little bit of extra logic to the generated batch file, that detects exit code 2, overwrites it with 0, and emits a clear warning for the user and Visual Studio to detect.

Comment 1

[Max Vollmer (they/them)]

Attachment: Bug 1755305 - Fixes mach warnings detected as errors by Visual Studio r=mhentges

Comment 2

[Max Vollmer (they/them)]

The clean target in Visual Studio projects in fact uses an invalid mach command. See also this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1670357

The correct command would be clobber, but that deletes the Visual Studio project files while Visual Studio is running, which it doesn't like too much.

A full build after clobber also causes errors, probably due to the environment not being correctly set:

lld-link: error: <root>: undefined symbol: mainCRTStartup
configure: error: installation or configuration problem: compiler cannot create executables.

Comment 3

[Max Vollmer (they/them)]

Attachment: Bug 1755305 - Fix invalid mach command for Visual Studio clean target r=mhentges

Comment 4

[Max Vollmer (they/them)]

So if a full build did work, then running clobber+build from Visual Studio would work. You'd be pulling the rug from under Visual Studio's feet, and then knit a new one under it before it looks down.

The first step is to fix the clean command (use clobber), update the docs that this is half-broken currently, and keep this bug open on low priority to fix the build environment issue in the future.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95fe1ac0e7f3
Fix invalid mach command for Visual Studio clean target r=mhentges DONTBUILD

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/95fe1ac0e7f3