1755553 - Fix a few strict warnings in SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

When enabling strict checking a few warnings about undefined variables and incorrect use of tab.hidden pop up in the error console.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1755553-fixhidden-25312.patch

tab,hidden is getter only and can not be set directly.
[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: tab status not correctly restored.
Testing completed (on m-c, etc.): 2.53.12b1 pre
Risk to taking this patch (and alternatives if risky): low risk
String changes made by this patch: --

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1755553-strict-25312.patch

A few undefined variables.
[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: none until we enable strict mode then it breaks.
Testing completed (on m-c, etc.): 2.53.12b1 pre
Risk to taking this patch (and alternatives if risky): trivial.
String changes made by this patch: --

Comment 3

[Ian Neal]

Comment on attachment 9264047 [details] [diff] [review]
1755553-fixhidden-25312.patch

[Triage Comment]
LGTM r/a=me

Comment 4

[Ian Neal]

Comment on attachment 9264048 [details] [diff] [review]
1755553-strict-25312.patch

[Triage Comment]
LGTM r/a=me

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9264047 [details] [diff] [review]
1755553-fixhidden-25312.patch

Didn't notice that this was already fixed in central via Bug 1479890 so we can take this patch instead.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c5eea7f78fda
Fix some uninitialized variables to please strict mode. r=IanN

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f43ef6b211df6dc1daeec37c591c220f83bd751f
Fix some uninitialized variables to please strict mode. r=IanN a=IanN