1755559 - --gecko-profile does not work for displaylist_mutate talos test

Status: NEW

(Testing :: Performance, defect, P2)

Description

[Miko Mynttinen]

STR: |mach talos-test -a displaylist_mutate --gecko-profile|

20:36:37     INFO -   'TPPROFILINGINFO': '{"gecko_profile_interval": 2, "gecko_profile_entries": '
20:36:37     INFO -                      '2000000, "gecko_profile_dir": "/tmp/tmptxc1p3ka", '
20:36:37     INFO -                      '"gecko_profile_features": '
20:36:37     INFO -                      '"js,leaf,stackwalk,cpu,threads", "gecko_profile_threads": '
20:36:37     INFO -                      '"GeckoMain,Compositor,WR,Renderer"}',

The profiler warns

Unrecognized feature "threads".

and the profiles seem to contain only few seconds of measurements.

Comment 1

[Markus Stange [:mstange]]

Looks like we have two remaining holdovers of the threads feature: https://searchfox.org/mozilla-central/search?q=cpu%2Cthreads&path=

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1729815

Comment 3

[Miko Mynttinen]

I removed the threads parameter locally and encountered another issue. The profiles seem to only record some portions of the test end.
Increasing the value here https://searchfox.org/mozilla-central/source/testing/talos/talos/test.py#1137 seems to fix it.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you for looking into this.

The "threads" feature hasn't done anything for a long time, so other issues would be unrelated.
Yes, increasing the number of "entries" should help with too-short profiles.

I'd be happy to review if you'd like to submit a patch. Please let me know otherwise.

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1755559 - remove the obsolete 'threads' profiler feature from automated performance tests, r=mstange.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a742bb7e5a16
remove the obsolete 'threads' profiler feature from automated performance tests, r=mstange,perftest-reviewers,sparky.

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a742bb7e5a16

Comment 8

[Florian Quèze [:florian]]

Unassigning, as I think Greg wanted to keep this bug open to fix the profiler buffer size (ideally the buffer size used for all perf tests should be reviewed and made large enough for this to not be a problem again for another test).

Comment 9

[Eng_Esther]

Hey Sparky,
Do we want to keep this open?
Also, is there a bug ticket opened for any further work?
Thanks.

Comment 10

[Greg Mierzwinski [:sparky]]

Yes, we should leave this open until the issue Florian mentioned (buffer size) is resolved.

Comment 11

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:andrej, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.