Code coverage missing for RLBoxed code
Categories
(Core :: Security: RLBox, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Source code belonging to RLBoxed libraries is showing up as uncovered. We need to find a way to make sure RLBoxed code is considered by our code coverage machinery.
I'm not sure how the RLBox build system works, if it generates new source files we'd need to find a way to map them back to the original (similarly to what we should do for IDL files, bug 1465027, but in the RLBox case it's more important).
A quick fix could be to build the code coverage build with wasm-sandboxing disabled. I'm not sure if there is any downside in doing that.
|
||
Comment 1•2 years ago
|
||
The usual instrumentation for code coverage is based on debug information (which is not the case for source-based ccov). So a solution could be to try to generate the correct debug info to reflect the origins of the code but I've no idea if it's something easy or not.
I don't know if it could impact negatively debug experience (with gdb, lldb, ...).
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8dab590bff55 Disable RLBox in code coverage builds. r=firefox-build-system-reviewers,glandium DONTBUILD
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•