If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

PR_Open() needs the unix equivalent of O_EXCL flag

RESOLVED FIXED

Status

NSPR
NSPR
P3
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: larryh (gone), Assigned: larryh (gone))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

18 years ago
NSPR's PR_Open() function needs the equivalent of Unix's O_EXCL flag.

... Implementation for Netscape's Unix and Win32 platforms has been developed,
tested. It is waiting commit on implementations for MAC. ... Steve, can you
help?

Also, other platforms may want to implement similar capability (OS/2, BeOS).
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

18 years ago
Check in parts.
Note: MAC platform will be checked in by Steve Dagley after this checkin.

cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag" pr/tests/op_excl.c
RCS file: /cvsroot/mozilla/nsprpub/pr/tests/op_excl.c,v
done
Checking in pr/tests/op_excl.c;
/cvsroot/mozilla/nsprpub/pr/tests/op_excl.c,v  <--  op_excl.c
initial revision: 1.1
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/include/prio.h
Checking in pr/include/prio.h;
/cvsroot/mozilla/nsprpub/pr/include/prio.h,v  <--  prio.h
new revision: 3.18; previous revision: 3.17
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/src/md/unix/unix.c
Checking in pr/src/md/unix/unix.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/unix.c,v  <--  unix.c
new revision: 3.31; previous revision: 3.30
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"
pr/src/md/windows/ntio.c
Checking in pr/src/md/windows/ntio.c;
/cvsroot/mozilla/nsprpub/pr/src/md/windows/ntio.c,v  <--  ntio.c
new revision: 3.15; previous revision: 3.14
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"
pr/src/md/windows/w95io.c
Checking in pr/src/md/windows/w95io.c;
/cvsroot/mozilla/nsprpub/pr/src/md/windows/w95io.c,v  <--  w95io.c
new revision: 3.12; previous revision: 3.11
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/tests/Makefile
Checking in pr/tests/Makefile;
/cvsroot/mozilla/nsprpub/pr/tests/Makefile,v  <--  Makefile
new revision: 3.39; previous revision: 3.38
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/tests/ntioto.c
Checking in pr/tests/ntioto.c;
/cvsroot/mozilla/nsprpub/pr/tests/ntioto.c,v  <--  ntioto.c
new revision: 1.2; previous revision: 1.1
done
cvs commit -m"BugZilla 17558. Add PR_Open() PR_EXCL flag"  pr/tests/runtests.ksh
Checking in pr/tests/runtests.ksh;
/cvsroot/mozilla/nsprpub/pr/tests/runtests.ksh,v  <--  runtests.ksh
new revision: 1.8; previous revision: 1.7
done

Updated

18 years ago
Blocks: 17907
(Assignee)

Comment 2

18 years ago
Checking in the MAC specific parts.
R: sdagley, larryh
Approved by chofmann

Checking in macio.c;
/cvsroot/mozilla/nsprpub/pr/src/md/mac/macio.c,v  <--  macio.c
new revision: 3.23; previous revision: 3.22
done
(Assignee)

Comment 3

18 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 4

18 years ago
The pthreads version did not get the PR_EXCL change.
I fixed this on the NSPRPUB_RELEASE_4_0_BRANCH.
/cvsroot/mozilla/nsprpub/pr/src/pthreads/ptio.c, revision 3.42.4.10

Comment 5

18 years ago
Just wanted to acknowledge that Kurt J. Lidl <lidl@pix.net>
independently (and earlier than I did) fixed the PR_EXCL bug
in ptio.c.  He sent us a patch on 25 Jan 2000.

Updated

18 years ago
No longer blocks: 17907
You need to log in before you can comment on or make changes to this bug.