1755850 - GCC build issue: mailnews/base/src/nsMsgFolderCache.cpp |nsresult| needs casting to be used against "%x" format string.

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[ISHIKAWA, Chiaki]

Attachment: casting |rv| of type |nsresult| to |uint32_t|

I am locally compiling C-C TB using GCC with -Werror flag (ignoring some warnings).
This is to check various language issues early on.

There are "%x" format specifier used for printing |nsresult| within |MOZ_LOG()|.

They need to be cast to an integer value or otherwise GCC complains that value of type |nsresult| cannot be used for "%x".
Thus with -Wall, build fails.

The attached patch fixes the issue.
It has been used locally and tryserver push for a while.
For example, see https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7fb3853717d7aa5ba14eb41d5452f6c4e8486def

Comment 1

[Magnus Melin [:mkmelin]]

Comment on attachment 9264319 [details]
casting |rv| of type |nsresult| to |uint32_t|

Thanks, r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b966f4ff2bc5
casting nsresult to <static_cast>(uint32_t) to be used for %x format specifier. r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c2a8f73f0467
Follow-up: Run clang-format. rs=clang-format CLOSED TREE DONTBUILD