Closed Bug 1756241 Opened 2 years ago Closed 2 years ago

Tearing off tabs to a different monitor opens a new window on the original screen


(Firefox :: Tabbed Browser, defect)




99 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox97 --- unaffected
firefox98 --- unaffected
firefox99 + fixed


(Reporter: RyanVM, Assigned: emilio)




(Keywords: regression)


(4 files)

[Tracking Requested - why for this release]: User-facing visible regression

 2:05.31 INFO: No more integration revisions, bisection finished.
 2:05.31 INFO: Last good revision: 3eec0fc28bd504d3c44f803222bff5acb4118eda
 2:05.31 INFO: First bad revision: 01d8e901bb369cad52f885808fd0d8ebb5176ca7
 2:05.31 INFO: Pushlog:

If I drag a tab off the tab strip from my primary monitor to my secondary monitor, it no longer opens a window on the secondary monitor as expected. It instead opens on the primary monitor still. I have dual 4K screens and run at 200% scaling in case that ends up being important.

Flags: needinfo?(emilio)

Probably a regression from bug 1755315 instead, but will look

Assignee: nobody → emilio

Passing the widget makes sure that in mixed dpi situations the pixels match
that of all other events.

The windows code was working around this by storing CSS pixels directly, but
with that tweak it's no longer needed.

Chances are I need to undo similarish workarounds on other platforms like,
will test there.

The root cause of the bug is fixed by the previous patch. This patch improves
the calculations to work properly across mixed dpi displays (which doesn't work
on release either by any stretch).

Hopefully it's somewhat straight-forward to follow.

Depends on D139243

(I still need to check behavior with this patch on macOS and Linux, as per the commit message there's probably some other workarounds that can go now).

Component: DOM: Core & HTML → Tabbed Browser
Product: Core → Firefox
See Also: → 1288760, 1306309

This gives proper window-relative, CSS-scaled window coordinates on X11.

Before D139243 the coordinates were only correct in non-HiDPI

D139243 makes drag events more similar to all other events (passing down the
widget the coordinates are relative to and so on), so we need to use the same
coordinate space as everything else now (widget-relative).

Depends on D139245

Ok with the patches above all drag coordinates behave correctly in various HiDPI / multi-monitor setups in all desktop platforms, afaict

Flags: needinfo?(emilio)
Has Regression Range: --- → yes
Pushed by
Make Windows DragService have the same coordinate system as all other drag and mouse events. r=tnikkel
Improve tab dragging calculations to work correctly between mixed-dpi screens. r=dao
Fix drag coordinates on X11 after D139243. r=stransky
Fix drag coordinates on macOS after D139243. r=mac-reviewers,bradwerth
Blocks: 1306309
See Also: 1306309
Flags: qe-verify+
Regressions: 1767165
You need to log in before you can comment on or make changes to this bug.