1756528 - TextRange::Crop doesn't crop siblings

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

I discovered this while working on cached text selection in bug 1741793.

Scenario:

1. <div><p id="p1">a</p><p id="p2">b</p></div>
2. "b" is selected.
3. Get SelectionRanges from the div. The returned range will contain only p2.
4. Call Crop() on the range, passing it the Accessible for p1.
5. Crop should return false. Instead, it returns true! The range still contains p2.

This causes HyperTextAccessibleBase::SelectionBoundsAt to return the wrong result for p1. This probably doesn't matter to clients, but it's certainly wrong.

Curiously, HyperTextAccessible::SelectionBoundsAt has the same bug, but it doesn't use TextRange::Crop.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1756528: Fix cropping of siblings in TextRange::Crop.

I couldn't really understand the previous code well enough to fix it, so I reimplemented it to be easier to work with (I hope).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/325ad2f9160c
Fix cropping of siblings in TextRange::Crop. r=eeejay

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/325ad2f9160c