Closed
Bug 1756655
Opened 3 years ago
Closed 3 years ago
Remove preprocessing conditionals from UA sheets
Categories
(Core :: CSS Parsing and Computation, task, P3)
Tracking
()
RESOLVED
FIXED
100 Branch
People
(Reporter: Gijs, Assigned: sclements)
References
Details
(Whiteboard: [fidefe-2022-mr1-css-linting])
Attachments
(1 file)
These sheets: https://searchfox.org/mozilla-central/search?q=%25if&path=layout**css&case=false®exp=false
layout/style/res/forms.css
layout/style/res/html.css
layout/style/res/scrollbars.css
layout/style/res/ua.css
have some platform-specific checks for android/windows/macOS etc. They can all be replaced with the relevant media queries.
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Updated•3 years ago
|
Attachment #9266256 -
Attachment description: Bug 1756655 - Remove ifdefs from UA style sheets → Bug 1756655 - Remove ifdefs from UA style sheets r=emilio
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd50b8570bd8
Remove ifdefs from UA style sheets r=emilio
Comment 3•3 years ago
|
||
Backed out for causing mochitest failures on browser_parsable_css.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://gre-resources/html.css: Unexpected token ‘not(’ in media list
Flags: needinfo?(sclements)
Assignee | ||
Comment 4•3 years ago
|
||
Sorry about that! Fixing a typo caused that test to pass locally.
Flags: needinfo?(sclements)
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80346599cb61
Remove ifdefs from UA style sheets r=emilio
Comment 6•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Updated•3 years ago
|
Component: General → CSS Parsing and Computation
Product: Toolkit → Core
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•