Closed
Bug 1659583
Opened 4 years ago
Closed 3 years ago
[meta] Remove preprocessor conditionals from CSS files
Categories
(Firefox :: General, task)
Firefox
General
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: Gijs, Unassigned)
References
Details
(Keywords: meta)
For more contexts, see bug 1659444.
Query that currently captures all of these: https://searchfox.org/mozilla-central/search?q=%25if&path=css .
There are broadly the following cases:
%if 0
, especially for license headers. These can just be converted to normal comments. This is now covered by bug 1747459.- CSS that can move from "shared" files to OS-specific files
- CSS using
MENUBAR_CAN_AUTOHIDE
, which can probably switch to using an attribute on the root (moving the ifdef into browser.xhtml, where it's already used anyway) - CSS that is platform-specific and can switch to using an attribute, media query, or other mechanism
- CSS that is inside the UA stylesheets. There we can use something like:
/*
%ifdef MOZ_WIDGET_GTK
*/
...
/*
%endif
*/
to hide the preprocessor markup from a linter.
Comment 1•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Component: General → WebRTC
Product: Firefox → Core
Reporter | ||
Updated•4 years ago
|
Component: WebRTC → General
Product: Core → Firefox
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Keywords: meta
Summary: Remove preprocessor conditionals from CSS files → [meta] Remove preprocessor conditionals from CSS files
Comment 2•3 years ago
|
||
This has no more dependencies and there are no more %if
s in our CSS files
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
status-firefox100:
--- → fixed
status-firefox81:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•