Add telemetry for the top pick/best match checkbox in the preferences UI
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox99 | --- | verified |
People
(Reporter: adw, Assigned: daisuke)
References
()
Details
Attachments
(4 files)
Per the best match spec, we need telemetry for the following:
- Top Pick preference toggles
- Top Pick preferences learn more clicked
For the preference toggle, we can follow the example of the three other Suggest prefs. For each of these prefs, we have two probes:
- An event recorded when the preference is changed:
- The user's current value of the pref is recorded in telemetry environment:
For the learn more link, we probably want to record an event when it's clicked.
Rebecca, does that sound good?
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Comment 3•3 years ago
|
||
yep, event telemetry for preference toggles and learn more clicks sound good to me.
Jeff, could we get the new Preference for Best Match added to clients_daily
, and aggregated by choosing the final recorded value for the Preference on a given day?
Reporter | ||
Comment 4•3 years ago
|
||
(In reply to Rebecca BurWei from comment #3)
Jeff, could we get the new Preference for Best Match added to
clients_daily
The pref name is: browser.urlbar.suggest.bestmatch
Reporter | ||
Comment 5•3 years ago
|
||
Data review request for three new probes related to the top pick feature of Firefox Suggest: two new events and one preference addition to telemetry environment data
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Comment 7•3 years ago
|
||
Proposed change to clients_daily in https://github.com/mozilla/bigquery-etl/pull/2764 up for review.
Reporter | ||
Comment 8•3 years ago
|
||
Comment on attachment 9265446 [details]
data-request.md
Clearing data review request until we know what we're doing here.
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f005ae12bb44 Add telemetry for best match checkbox in the preferences page. r=adw https://hg.mozilla.org/integration/autoland/rev/89b398ecfec3 Add telemetry for best match learn more link in the preferences page. r=preferences-reviewers,adw,Gijs
Reporter | ||
Comment 10•3 years ago
|
||
STR for QA:
- Enable Firefox Suggest and best match (
browser.urlbar.bestMatch.enabled
) - Open about:preferences#privacy and scroll down to the Address Bar section
- Click the "Top pick" checkbox
- Open about:telemetry and search for
browser.ui.interaction.preferences_panePrivacy
- Verify the Keyed Scalars section appears with
browser.ui.interaction.preferences_panePrivacy
under the parent process, and in the table under that,firefoxSuggestBestMatch
appears with a Value of 1 - Go back to about:preferences and click the "Learn more" link next to the "Top pick" checkbox
- Go back to about:telemetry and refresh the page (search for
browser.ui.interaction.preferences_panePrivacy
again if necessary) - In addition to
firefoxSuggestBestMatch
from step 5, verify thatfirefoxSuggestBestMatchLearnMore
now appears in the table with a Value of 1
Comment 11•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f005ae12bb44
https://hg.mozilla.org/mozilla-central/rev/89b398ecfec3
Comment 12•3 years ago
|
||
I have verified this issue on the latest Nightly 99.0a1 (Build ID: 20220304094153) on Windows 10 x64, macOS 10.15.7 and Linux Ubuntu 20.04 x64.
- In order to verify this issue we have used the STR from comment 10.
- Each time the
Top pick
checkbox is clicked, the value of thefirefoxSuggestBestMatch
keyed scalar increases with 1. - Each time the
Learn more
link is clicked, the value of thefirefoxSuggestBestMatchLearnMore
keyed scalar increases with 1. - Both of the
firefoxSuggestBestMatch
andfirefoxSuggestBestMatchLearnMore
keyed scalars appear withbrowser.ui.interaction.preferences_panePrivacy
under the parent process in theabout:telemetry
page.
Comment hidden (obsolete) |
Updated•3 years ago
|
Comment 14•3 years ago
|
||
(In reply to Alexandru Ionescu (needinfo me) [:alexandrui - PTO returning April 12] from comment #13)
(In reply to Pulsebot from comment #9)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f005ae12bb44
Add telemetry for best match checkbox in the preferences page. r=adw
https://hg.mozilla.org/integration/autoland/rev/89b398ecfec3
Add telemetry for best match learn more link in the preferences page.
r=preferences-reviewers,adw,Gijs== Change summary for alert #33467 (as of Sat, 05 Mar 2022 06:03:38 GMT) ==
Improvements:
Ratio Test Platform Options Absolute values (old vs new) 16% nytimes FirstVisualChange windows10-64-shippable-qr cold fission webrender 413.92 -> 347.42 13% nytimes loadtime windows10-64-shippable-qr cold fission webrender 1,793.02 -> 1,562.71 4% buzzfeed PerceptualSpeedIndex windows10-64-shippable-qr cold fission webrender 799.00 -> 764.92 For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33467
:alexandrui adding a telemetry probe is unlikely to cause page load improvements. Could you revisit the alert to see if there's a more likely cause?
Updated•2 years ago
|
Description
•