1757446 - [css-grid-3] Enable layout.css.grid-template-masonry-value.enable by default (beyond Nightly)

Status: RESOLVED WONTFIX

(Core :: Layout: Grid, task, P3)

Description

[Daniel Holbert [:dholbert]]

Filing this bug to track enabling CSS Masonry ( https://drafts.csswg.org/css-grid-3/#masonry-layout ) by default -- i.e. making layout.css.grid-template-masonry-value.enabled default to true.

(Currently it's enabled with a Nightly-specific guard.)

This probably needs to wait for at least one other engine to commit to implementation, at a minimum.

Also note, masonry is currently listed in the "Nightly Experiments" section at https://searchfox.org/mozilla-central/rev/73a8000b0c0eb527faef01ea17c6d2398622a386/toolkit/components/featuregates/Features.toml (and on MDN) -- we should probably remove it from there once we're ready to ship it (i.e. as part of the patch that enables it unconditionally)

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)

This probably needs to wait for at least one other engine to commit to implementation, at a minimum.

(Some of the bugs in bug 1607954's "blocks" and "Depends on" lists would probably block this, too. We can triage which defects specifically need fixing when we're closer to considering-shipping.)

Comment 2

[Sarah Clements [:sclements]]

Hi, we'd like to use this in Firefox view. Can someone give me an idea of when we can use this outside of Nightly?

Comment 3

[Daniel Holbert [:dholbert]]

[moving masonry alias and web-feature keyword and most bug-relationships to the metabug, bug 1981604]

Comment 4

[Daniel Holbert [:dholbert]]

(For most of the remaining related-bugs here that I haven't yet moved to the metabug, they're related to our current experimental implementation, so they'll likely/hopefully go away when we update to match the standardized version. I'm not going to move those to the metabug for now, in the interests of keeping its dependencies somewhat easier to reason about and focused on the to-be-implemented updated version of the feature.)

Comment 5

[Daniel Holbert [:dholbert]]

[removing platform-feature-tracking stuff here; we're tracking the standardized version of this feature in bug 1981604, per the initial comment there. This bug here might be closed at some point, since our proof-of-concept version will be replaced.]

Comment 6

[Daniel Holbert [:dholbert]]

(in particular the layout.css.grid-template-masonry-value.enable about:config pref mentioned in comment 0 will no longer be relevant with the new implementation, because the CSSWG recently resolved to standardize on using a display value to toggle masonry rather than a grid-template-* value.)

Comment 7

[Daniel Holbert [:dholbert]]

(I'll adjust the title to make that clearer, and wontfix this. We'll want to have a similar "enable the pref for the feature" bug that's associated with bug 1981604, but we might as well start fresh rather than morphing this bug.)