1814481 - Assertion failure: mEnd != kAutoLine (Extent is undefined for abs.pos. 'auto'), at /layout/generic/nsGridContainerFrame.cpp:415

Status: NEW

(Core :: Layout: Grid, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 3479f77e7402 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 3479f77e7402 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: mEnd != kAutoLine (Extent is undefined for abs.pos. 'auto'), at /layout/generic/nsGridContainerFrame.cpp:415

    ==981636==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fdb547bf2e9 bp 0x7ffdb9c6b290 sp 0x7ffdb9c6b290 T981636)
    ==981636==The signal is caused by a WRITE memory access.
    ==981636==Hint: address points to the zero page.
        #0 0x7fdb547bf2e9 in nsGridContainerFrame::GridItemInfo::MaybeInhibitSubgridInMasonry(nsGridContainerFrame*, unsigned int) /layout/generic/nsGridContainerFrame.cpp
        #1 0x7fdb547c7ef7 in nsGridContainerFrame::Grid::PlaceGridItems(nsGridContainerFrame::GridReflowInput&, RepeatTrackSizingInput const&) /layout/generic/nsGridContainerFrame.cpp:4860:15
        #2 0x7fdb547dde69 in nsGridContainerFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) /layout/generic/nsGridContainerFrame.cpp:8633:12
        #3 0x7fdb54751cba in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) /layout/generic/nsContainerFrame.cpp:1012:14
        #4 0x7fdb54751179 in nsCanvasFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) /layout/generic/nsCanvasFrame.cpp:755:7
        #5 0x7fdb54751cba in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) /layout/generic/nsContainerFrame.cpp:1012:14
        #6 0x7fdb5479ab90 in nsHTMLScrollFrame::ReflowScrolledFrame(mozilla::ScrollReflowInput&, bool, bool, mozilla::ReflowOutput*) /layout/generic/nsGfxScrollFrame.cpp:863:3
        #7 0x7fdb5479b91f in nsHTMLScrollFrame::ReflowContents(mozilla::ScrollReflowInput&, mozilla::ReflowOutput const&) /layout/generic/nsGfxScrollFrame.cpp:999:3
        #8 0x7fdb547a061d in nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) /layout/generic/nsGfxScrollFrame.cpp:1426:3
        #9 0x7fdb547228d7 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) /layout/generic/nsContainerFrame.cpp:1052:14
        #10 0x7fdb54722034 in mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) /layout/generic/ViewportFrame.cpp:385:7
        #11 0x7fdb5461da7f in mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) /layout/base/PresShell.cpp:9654:11
        #12 0x7fdb5464194f in mozilla::PresShell::ProcessReflowCommands(bool) /layout/base/PresShell.cpp:9831:22
        #13 0x7fdb546273f5 in DoFlushLayout /layout/base/PresShell.cpp:9902:10
        #14 0x7fdb546273f5 in mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) /layout/base/PresShell.cpp:4385:11
        #15 0x7fdb5288efd3 in FlushPendingNotifications /builds/worker/workspace/obj-build/dist/include/mozilla/PresShell.h:1454:5
        #16 0x7fdb5288efd3 in mozilla::EventStateManager::FlushLayout(nsPresContext*) /dom/events/EventStateManager.cpp:5970:16
        #17 0x7fdb5288b710 in mozilla::EventStateManager::PreHandleEvent(nsPresContext*, mozilla::WidgetEvent*, nsIFrame*, nsIContent*, nsEventStatus*, nsIContent*) /dom/events/EventStateManager.cpp:780:7
        #18 0x7fdb5463bb18 in mozilla::PresShell::EventHandler::DispatchEvent(mozilla::EventStateManager*, mozilla::WidgetEvent*, bool, nsEventStatus*, nsIContent*) /layout/base/PresShell.cpp:8248:39
        #19 0x7fdb5463653c in mozilla::PresShell::EventHandler::HandleEventWithCurrentEventInfo(mozilla::WidgetEvent*, nsEventStatus*, bool, nsIContent*) /layout/base/PresShell.cpp:8217:17
        #20 0x7fdb54635d02 in mozilla::PresShell::EventHandler::HandleEventUsingCoordinates(nsIFrame*, mozilla::WidgetGUIEvent*, nsEventStatus*, bool) /layout/base/PresShell.cpp:7166:30
        #21 0x7fdb546349d4 in mozilla::PresShell::EventHandler::HandleEvent(nsIFrame*, mozilla::WidgetGUIEvent*, bool, nsEventStatus*) /layout/base/PresShell.cpp:6969:12
        #22 0x7fdb54633f89 in mozilla::PresShell::HandleEvent(nsIFrame*, mozilla::WidgetGUIEvent*, bool, nsEventStatus*) /layout/base/PresShell.cpp:6912:23
        #23 0x7fdb5421a7a2 in nsViewManager::DispatchEvent(mozilla::WidgetGUIEvent*, nsView*, nsEventStatus*) /view/nsViewManager.cpp:678:18
        #24 0x7fdb5421a548 in nsView::HandleEvent(mozilla::WidgetGUIEvent*, bool) /view/nsView.cpp:1156:9
        #25 0x7fdb54250dc7 in mozilla::widget::PuppetWidget::DispatchEvent(mozilla::WidgetGUIEvent*, nsEventStatus&) /widget/PuppetWidget.cpp:351:37
        #26 0x7fdb5044846b in mozilla::layers::APZCCallbackHelper::DispatchWidgetEvent(mozilla::WidgetGUIEvent&) /gfx/layers/apz/util/APZCCallbackHelper.cpp:509:21
        #27 0x7fdb53a86af6 in DispatchWidgetEventViaAPZ /dom/ipc/BrowserChild.cpp:1704:10
        #28 0x7fdb53a86af6 in mozilla::dom::BrowserChild::HandleRealMouseButtonEvent(mozilla::WidgetMouseEvent const&, mozilla::layers::ScrollableLayerGuid const&, unsigned long const&) /dom/ipc/BrowserChild.cpp:1667:3
        #29 0x7fdb53a87ffb in mozilla::dom::BrowserChild::RecvRealMouseButtonEvent(mozilla::WidgetMouseEvent const&, mozilla::layers::ScrollableLayerGuid const&, unsigned long const&) /dom/ipc/BrowserChild.cpp:1634:3
        #30 0x7fdb53a88168 in mozilla::dom::BrowserChild::RecvSynthMouseMoveEvent(mozilla::WidgetMouseEvent const&, mozilla::layers::ScrollableLayerGuid const&, unsigned long const&) /dom/ipc/BrowserChild.cpp:1599:8
        #31 0x7fdb53b989ee in mozilla::dom::PBrowserChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PBrowserChild.cpp:5493:80
        #32 0x7fdb53c1002b in mozilla::dom::PContentChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PContentChild.cpp:8717:32
        #33 0x7fdb4fd3c22a in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /ipc/glue/MessageChannel.cpp:1800:25
        #34 0x7fdb4fd38ea7 in mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message>>) /ipc/glue/MessageChannel.cpp:1725:9
        #35 0x7fdb4fd399d5 in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) /ipc/glue/MessageChannel.cpp:1525:3
        #36 0x7fdb4fd3ad0f in mozilla::ipc::MessageChannel::MessageTask::Run() /ipc/glue/MessageChannel.cpp:1623:14
        #37 0x7fdb4f120185 in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:539:16
        #38 0x7fdb4f11b75c in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:852:26
        #39 0x7fdb4f11a32a in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:684:15
        #40 0x7fdb4f11a685 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:462:36
        #41 0x7fdb4f123a86 in operator() /xpcom/threads/TaskController.cpp:188:37
        #42 0x7fdb4f123a86 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_2>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:546:5
        #43 0x7fdb4f138f85 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1197:16
        #44 0x7fdb4f13f2ad in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:477:10
        #45 0x7fdb4fd42173 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #46 0x7fdb4fc63d68 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:381:10
        #47 0x7fdb4fc63c71 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #48 0x7fdb4fc63c71 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #49 0x7fdb54283268 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:148:27
        #50 0x7fdb564d5b5b in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:742:20
        #51 0x7fdb4fd43039 in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #52 0x7fdb4fc63d68 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:381:10
        #53 0x7fdb4fc63c71 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #54 0x7fdb4fc63c71 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #55 0x7fdb564d56b8 in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:675:34
        #56 0x55901b172ce0 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #57 0x55901b172ce0 in main /browser/app/nsBrowserApp.cpp:353:18
        #58 0x7fdb6387cd8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
        #59 0x7fdb6387ce3f in __libc_start_main csu/../csu/libc-start.c:392:3
        #60 0x55901b149348 in _start (/home/jkratzer/builds/m-c-20230131042526-fuzzing-debug/firefox-bin+0x5b348) (BuildId: e14b2fb1456bc91eb6e9960ad62ce3ad688af1b9)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /layout/generic/nsGridContainerFrame.cpp in nsGridContainerFrame::GridItemInfo::MaybeInhibitSubgridInMasonry(nsGridContainerFrame*, unsigned int)
    ==981636==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Comment 3

[Bugmon [:jkratzer for issues]]

Verified bug as reproducible on mozilla-central 20230201215112-b7f075124503.
Unable to bisect testcase (Testcase reproduces on start build!):

Start: 5ec687bd6a86927844a76b26067aa18ed4a27b5a (20220203003951)
End: 3479f77e7402f18d6e3638ff131c0f35386fb493 (20230131042526)
BuildFlags: BuildFlags(asan=False, tsan=False, debug=True, fuzzing=True, coverage=False, valgrind=False, no_opt=False, fuzzilli=False, nyx=False)

Comment 4

[Bugmon [:jkratzer for issues]]

Bugmon was unable reproduce this issue.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 5

[Jason Kratzer [:jkratzer]]

A change to the Taskcluster build definitions over the weekend caused Bugmon to fail when reproducing issues. This issue has been corrected. Re-enabling bugmon.

Comment 6

[Bugmon [:jkratzer for issues]]

Testcase crashes using the initial build (mozilla-central 20230131042526-3479f77e7402) but not with tip (mozilla-central 20231222213932-8989af6649bf.)

The bug appears to have been fixed in the following build range:

Start: a63bafb44df0811c56c57b1fadd1c10261fd8c3e (20231219233048)
End: 9ac6d461916454c17cd8c7dfc7f73401ef3da12a (20231220020601)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a63bafb44df0811c56c57b1fadd1c10261fd8c3e&tochange=9ac6d461916454c17cd8c7dfc7f73401ef3da12a

jkratzer, can you confirm that the above bisection range is responsible for fixing this issue?
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 7

[Jason Kratzer [:jkratzer]]

:dholbert, can you confirm if this was fixed via bug 1800563 or bug 1870906?