1757506 - Poor contrast for theActive tab with system dark theme on Linux

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Danny Colin [:sdk]]

Attachment: ff-active-tab.png

The active tab background color has a color to close the to tabbar background color. This makes it hard to see which tab is active.

This is a regression introduced by https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fc09cf8d7c91553b71d8e83d4118fa6be3287ac8&tochange=771fc3e75f1e6c5636f42d3c5df0091bb04ff06e

To fix both bug 1741293 and this issue, I propose that we use the previous background color value only for the active tab while keeping the new background color value for the toolbar. This solution is similar to the one implemented with the firefox dark theme.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1741293

Comment 2

[Emilio Cobos Álvarez [:emilio]]

This is on Adwaita dark? If so this was kind of intentional.
I don't see why the toolbar would need less contrast than the active tab or vice versa, but I don't have strong opinions either way. 301 Dao, though I'm happy to write the patch with whatever approach he prefers.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

I guess it'd be more consistent with the regular dark theme this way. I never noticed that the regular dark theme did this. Will send a patch.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1757506 - Restore selected tab background image. r=dao

This is closer to what the standard lwt dark mode does, and seems fair
enough. I don't mind much either way so if you feel strongly about it
lmk.

Comment 5

[Danny Colin [:sdk]]

This is on Adwaita dark?

Yes.

I don't see why the toolbar would need less contrast than the active tab or vice versa

bug 1741293 was trying to fix a different contrast issue with the download icon in the toolbar not having enough contrast vs. the toolbar background color. The solution was to use a darker background color. However, it also changed the background color for the active tab.

Another solution would be to revert bug 1741293 and instead of using a darker color for the toolbar background, we use a lighter blue color for the download icon in the toolbar. That way both the toolbar and active tab will have the same background color.

Comment 6

[James Graham [:jgraham]]

Emilio: Do you think we should land the patch and uplift to beta, or back out the original patch on beta?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

I don't have a strong opinion either way (I don't have a strong opinion on the patch to begin with, I use the theme and contrast seems enough for me, but the concern seems fair of course). So 301 Dao.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be157bc98d0b
Restore selected tab background image. r=dao

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1757506 - Make Adwaita dark accent color the same as Adwaita light. r=stransky

GTK3 doesn't have accent colors per se so we reuse the "selected item"
colors.

However, GTK4 does, and dark and light accent colors in libadwaita are
the same, so special-case Adwaita to copy the colors from the light
theme.

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/be157bc98d0b

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 9265859 [details]
Bug 1757506 - Restore selected tab background image. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Activate a dark system theme and compare toolbar and active tab colors with the image in comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty straightforward CSS fix
• String changes made/needed:

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9265859 [details]
Bug 1757506 - Restore selected tab background image. r=dao

Approved for 100.0b3

Comment 14

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d5c080d6da85

Comment 15

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue on release 99.
Verified - Fixed in latest Nightly 101.0a1 and Beta 100.0b3, using Ubuntu 20.