Closed Bug 1757642 Opened 7 months ago Closed 7 months ago

Remove operating-system/platform-related preprocessing conditionals from arrowscrollbox.css and menu.css

Categories

(Toolkit :: General, task, P3)

Desktop
All
task
Points:
1

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: Gijs, Assigned: sclements)

References

Details

(Whiteboard: [fidefe-2022-mr1-css-linting])

Attachments

(1 file)

The arrowscrollbox.css shared css file has a macOS specific rule that can just be moved into a media query.

menu.css is a funny case. It's a windows-specific file but it has an ifdef for XP_WIN. So what gives? Well, we used to support OS/2, and in bug 461650, 14 years ago, OS/2 people complained that we shouldn't change the menu styling in background windows there. We don't support OS/2 anymore, and the OS/2 ports of Firefox have all died off a few years back for various reasons. So I'd say we could probably just remove the conditional entirely.

Points: --- → 1
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbbcfe333292
remove ifdef from arrowscroll.css and windows menu.css r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Regressions: 1762913
You need to log in before you can comment on or make changes to this bug.