1757731 - Include more information into cc_form telemetry

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P1)

Description

[Dimi Lee [:dimi]]

In current cc_form telemetry, we lack the following information:

1. cc-type is not included in the extra_keys. This can be used in "detect" and "filled" method
2. cc-exp-year and cc-exp-month are merged to cc-exp. This prevents us from understanding whether we are performing particular bad (or good) while identifying "cc-exp", "cc-exp-month", or "cc-exp-year"
3. popup_shown doesn't indicate which field triggers the event. If we include the data, we can know the conversion rate (popup_shown -> popup_filled) by field type.

Comment 1

[Dimi Lee [:dimi]]

just realized the maximum number of keys in extra is 10, that is why we didn't include all the information in the beginning.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1757731 - P1. Move telemetry related function to FormAutofillTelemetryUtils.jsm r=sgalich,tgiles

This patch adds CreditCardTelemetryUtils object to process credit card related telemetry.
This patches doesn't change the logic regarding how we record telemetry.

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1757731 - P2. Add cc_form_v2 telemetry event to collect more detailed information r=sgalich,tgiles

The previous cc_form event telemetry lack the following information:

1. Field-specific information.

• cc-exp, cc-exp-month, and cc-exp-year are all merged to cc-exp
• no cc-type

2. Clear form action

The cc_form_v2 event telemetry aims to collect field specific
information so we can know whether we perform particular bad (or good)
on certain fields.

Depends on D141008

Comment 4

[Dimi Lee [:dimi]]

Attachment: request.md

Comment 5

[Andrei [:sancus]]

Comment on attachment 9267718 [details]
request.md

This seems like a reasonable change to me.

Data Review Form:

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

This collection is documented in its definitions files Events.yaml and in the Probe Dictionary at https://probes.telemetry.mozilla.org.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, using standard Telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Dimi Lee (:dimi) will permanently monitor this data.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data.

5. Is the data collection request for default-on or default-off?

Default on for all channels, countries, and locales.

6. Does the instrumentation include the addition of any new identifiers?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7acf17f439d
P1. Move telemetry related function to FormAutofillTelemetryUtils.jsm r=sgalich,tgiles
https://hg.mozilla.org/integration/autoland/rev/51956ca0b416
P2. Add cc_form_v2 telemetry event to collect more detailed information r=sgalich,tgiles

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d7acf17f439d
https://hg.mozilla.org/mozilla-central/rev/51956ca0b416