1757860 - If an Address Book card changes while being displayed or edited, the UI should update

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Changes to contacts are reflected in the list of contacts, but not in the details section. This is especially noticeable for CardDAV address books where there's any amount of network lag. We should add another listener to the addrbook-contact-updated (and addrbook-contact-deleted) notification and respond appropriately. I think if we are editing a contact when it changes the best response would be to prompt the user then (if they agree) discard any changes and restart the edit.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1757860 - Indicate CardDAV activity in the Address Book UI. r=aleca

This changes the icon of a CardDAV book if a network request is being made by that book. This can help the user see that something is happening and maybe understand why the UI changes seconds after an action is performed.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1757860 - Update the Address Book UI if a card changes while being displayed or edited. r=aleca

Depends on D148493

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/956bf9132290
Indicate CardDAV activity in the Address Book UI. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/560df0fdae34
Update the Address Book UI if a card changes while being displayed or edited. r=aleca

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9280013 [details]
Bug 1757860 - Indicate CardDAV activity in the Address Book UI. r=aleca

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: minor UI improvement
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9280014 [details]
Bug 1757860 - Update the Address Book UI if a card changes while being displayed or edited. r=aleca

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Address Book UI can be left in a broken state
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9280014 [details]
Bug 1757860 - Update the Address Book UI if a card changes while being displayed or edited. r=aleca

[Triage Comment]
Approved for beta

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9280013 [details]
Bug 1757860 - Indicate CardDAV activity in the Address Book UI. r=aleca

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.0beta6:
https://hg.mozilla.org/releases/comm-beta/rev/08648500ce77
https://hg.mozilla.org/releases/comm-beta/rev/9d2f22dac2f3