Closed Bug 1757928 Opened 3 years ago Closed 3 years ago

swipe to nav on windows does not perform navigation when opacity of ui element is 100%

Categories

(Core :: Panning and Zooming, defect, P2)

defect

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox97 --- unaffected
firefox98 --- unaffected
firefox99 --- disabled
firefox100 --- disabled
firefox101 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

I think the problem is here

https://searchfox.org/mozilla-central/rev/8f42809e51cb07aa4f5739932a06d14581e9dd4a/browser/base/content/browser-gestureSupport.js#735

The 4 value is because we use 0.25 for the pref value widget.swipe.success-threshold on macOS, but on Windows we changed it to 0.5

https://hg.mozilla.org/mozilla-central/rev/74fbc27b186244e9a67e7dfc11d849962f7143e8

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1753146

Has Regression Range: --- → yes

The severity field is not set for this bug.
:botond, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(botond)

This is on the release blocker list for the feature, so let's go with S2.

Severity: -- → S2
Flags: needinfo?(botond)
Priority: -- → P2
Attachment #9266255 - Attachment description: Bug 1757928. Scale opacity of swipe to navigate UI elements by the same value we use in SwipeTracker.cpp to determine if navigation happens. r?hiro → Bug 1757928. Make the swipe events sent by SwipeTracker have the same scale. r?hiro

Depends on D140185

Depends on: 1763121
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/417eb4c36b32 Make the swipe events sent by SwipeTracker have the same scale. r=hiro https://hg.mozilla.org/integration/autoland/rev/1acc8e04bbfa Add test. r=hiro
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

The patch landed in nightly and beta is affected.
:tnikkel, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(tnikkel)

Feature is disabled on beta.

Flags: needinfo?(tnikkel)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: