1757537 - swipe to nav on windows performs navigation when opacity of ui element is not 100%

Status: RESOLVED DUPLICATE of bug 1762885

(Core :: Panning and Zooming, defect, P2)

Description

[Timothy Nikkel (:tnikkel)]

Initially I thought the problem was here

https://searchfox.org/mozilla-central/rev/8f42809e51cb07aa4f5739932a06d14581e9dd4a/browser/base/content/browser-gestureSupport.js#735

I thought (maybe it's even true) the 4 value was because we use 0.25 for the pref value widget.swipe.success-threshold on macOS see

https://hg.mozilla.org/mozilla-central/rev/74fbc27b186244e9a67e7dfc11d849962f7143e8

But I changed the code to get the pref and uses it but it didn't fix the problem. I also tried changing the pref value to 0.25 and that didn't seem to fix the problem.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1753885

Comment 2

[Timothy Nikkel (:tnikkel)]

re: firefox99 --- affected

The feature is enabled nightly only right now, and I don't think we plan to change that before the next merge, so likely will be 99: disabled, but I'll leave it just in case (better to track and not need then the other way around).

Comment 3

[Timothy Nikkel (:tnikkel)]

Just reading through the SwipeTracker code, it seems somewhat broken. The mAxis field we only ever touch it to set destination/starting pos in StartAnimating, which is only called when we get PANGESTURE_END.

Comment 4

[Timothy Nikkel (:tnikkel)]

(In reply to Timothy Nikkel (:tnikkel) from comment #3)

Just reading through the SwipeTracker code, it seems somewhat broken. The mAxis field we only ever touch it to set destination/starting pos in StartAnimating, which is only called when we get PANGESTURE_END.

That seems to be on purpose, to animate the opacity either to 1 or to 0 upon either successfully reaching the point of navigating the page, or not.

I think that is probably not needed, I think the code in browser-gestureSupport.js handles that already, for example here it sets a transition on the opacity when ending the animation (the part that responds to user input events):

https://searchfox.org/mozilla-central/rev/ad7ecfa618ec3a65db8405d9f1125059fe4a6a15/browser/base/content/browser-gestureSupport.js#714

Comment 5

[Timothy Nikkel (:tnikkel)]

Today I can't seem to reproduce this anymore. I can reproduce the opposite actually, I can get the opacity to 100% but it doesn't navigate. So I filed that as bug 1757928, it has the fix described in comment 0. I'll leave this bug open to see if I can reproduce this bug again.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:botond, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Botond Ballo [:botond]]

Marking this as S3 since the issue does not affect a currently shipping configuration, but P2 because it's a potential blocker for the release of swipe-to-navigate.

Comment 8

[Timothy Nikkel (:tnikkel)]

I think this was probably bug 1762885.