1757993 - Add Telemetry probe for checkboxes in preference

Status: RESOLVED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Andrei Hajdukewycz [:sancus]]

We'd like to gather data on which preferences people have selected. For the first iteration of this, lets just stick to the checkboxes. These should map to a keyed scalar with 0 or 1 set for each key without any trouble. Some of them have subsequent select or text boxes and those can be ignored for now.

Comment 1

[Geoff Lankow (:darktrojan)]

In mail/components/preferences/test/browser we test every check box (or we did, and I hope the tests have been updated with the code), so the list of calls to testCheckboxes should be an easy way to get the preferences in question. Same with the radio buttons when we get there.

Comment 2

[Geoff Lankow (:darktrojan)]

… except the calendar preferences, because it's the calendar and everything about it is different just to be annoying.

Comment 3

[Sean Burke [:leftmostcat]]

Attachment: Bug 1757993 - report values of boolean preferences. r=darktrojan

Comment 4

[Sean Burke [:leftmostcat]]

Attachment: Bug 1757993 - remove non-applicable modelines. r=darktrojan

Depends on D141520

Comment 5

[Sean Burke [:leftmostcat]]

Attachment: dr-request.md

Comment 6

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 9268977 [details]
dr-request.md

Seems good to me, approved.

Data Review Form:

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Documentation included in the repository in the Scalars.yaml file. Complete list of collected booleans presently at comm/mail/base/content/msgMail3PaneWindow.js

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, using standard Telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Andrei Hajdukewycz(:sancus) will permanently monitor this data.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data.

5. Is the data collection request for default-on or default-off?

Default on for all channels, countries, and locales.

6. Does the instrumentation include the addition of any new identifiers?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a7975d64bf91
report values of boolean preferences. r=darktrojan
https://hg.mozilla.org/comm-central/rev/edfe8ca1ee0b
remove non-applicable modelines. r=darktrojan

Comment 8

[Takanori MATSUURA]

mail/components/preferences/preferences.xhtml still has non HTML-style comment.

Comment 9

[Sean Burke [:leftmostcat]]

Anywhere I wasn't certain that HTML-style comments would be preferred/consistent, I left them as-is. My focus was just on the bogus modelines.

Comment 10

[Takanori MATSUURA]

(In reply to Sean Burke [:leftmostcat] from comment #9)

Anywhere I wasn't certain that HTML-style comments would be preferred/consistent, I left them as-is. My focus was just on the bogus modelines.

I see.
In mail/components/preferences/colors.xhtml, you have fixed HTML-style comments.
So I assumed you would do the same fix in mail/components/preferences/preferences.xhtml too.

Comment 11

[Magnus Melin [:mkmelin]]

Did we intend to uplift this to 91 or not?

Comment 12

[Sean Burke [:leftmostcat]]

I believe the intent is not to uplift this.

Comment 13

[Andrei Hajdukewycz [:sancus]]

Yeah, with 102 so close I don't see much benefit to uplifting this.