Closed Bug 1758014 Opened 2 years ago Closed 2 years ago

Search Settings are no longer written to a temporary file first

Categories

(Firefox :: Search, defect, P2)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- wontfix
firefox97 --- wontfix
firefox98 --- wontfix
firefox99 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1758014 - Search settings should use an atomic operation when writing. r?barret
48 bytes, text/x-phabricator-request
Details | Review

In the switch from OS.File to IOUtils in bug 1671274 the change for the write function caused us to no longer write to a tmp file before moving that over the existing settings file.

A user has just reported that their default search engine was reset, and this was possibly related to low disk space. If we're not writing to a tmp file first, then these could be related.

Set release status flags based on info from the regressing bug 1671274

status-firefox97: --- → affected
status-firefox98: --- → affected
status-firefox99: --- → affected
status-firefox-esr91: --- → affected
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24ee3db1d077
Search settings should use an atomic operation when writing. r=barret
Has Regression Range: --- → yes

https://hg.mozilla.org/mozilla-central/rev/24ee3db1d077

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox99: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: