1758134 - No hover effect on the PiP player controls

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Affected Versions:

Nightly 99.a1, Beta 98 and Release 97.0.1

Tested on:

MacOS 11.6
Windows 10

Steps:

1. Navigate to https://www.youtube.com/ and play any video.
2. Hover the mouse over the PiP toggle button and click on it.
3. In the PiP Window - hover the mouse over the video controls - play/pause, mute/unmute, switch back to the window, and Close.

Expected Result:

The video controls of the PiP window should have a hover effect when mouse over.

Actual Result:

The video controls of the PiP window do not have a hover effect when mouse over.

Regression range:

Found commit message:
Bug 1707279 Fix picture-in-picture control do not always disappear r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D130838

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:shirshak55, since you are the author of the regressor, bug 1707279, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

The specific part of the bug 1707279 patch that's causing the issue is this line; from what I can tell, the addition of the body:not(:fullscreen) condition on the selector for the controls area as a whole is making that selector more specific than the one following it, which is the one that's supposed to apply the hover effect to each individual control, so that effect just never happens.

It isn't clear to me what the purpose of that particular change was in the context of the rest of the patch though, so I'm not sure what direction to start looking in for a fix; :shirshak55 or :mconley, do either of you recall any details about that?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey! Yes, this is one I do remember. The idea here was to avoid the 0.8 opacity rule when in fullscreen so that controls were either full visible (when the mouse had moved recently) or fully invisible (after the timeout fires), and not care about if the mouse is hovering for the half-way state (which is always true if fullscreened on a single display).

Comment 4

[Ania]

Let's consider fixing this for 100 for non-full screened PiP window states. Having no hover in full-screen is acceptable IMO.

Comment 5

[Dianna Smith [:diannaS]]

:mconley is this still something we want to address in fx100? There are only 2 betas left, and this is unassigned.

Comment 6

[kpatenio]

I think this is something we can fix soon. Will assign myself to this bug.

Comment 7

[kpatenio]

Attachment: Bug 1758134 - fix no hover effect appearing on PiP player control buttons. r=#pip-reviewers!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feea763a73a3
fix no hover effect appearing on PiP player control buttons. r=pip-reviewers,mhowell

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/feea763a73a3

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[kpatenio]

This does not require an uplift and can go through the current cycle.

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on Firefox 100.0(20220428192727) on macOS 11. Verified as fixed on Firefox 101.0b4(20220508185621) and Nightly 102.0a1(20220509190429) on Ubuntu 20.04, macOS 11 and Win10 64-bits.