1707279 - picture-in-picture control do not always disappear

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Peter deHaan [:pdehaan]]

This comment is copy/pasted from a community issue filed during the Foxfooding program.

---

Firefox Version: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0
Window Size (inner width and height): 1920x923

Steps to Reproduce

1. go to a page with video
2. start playing video
3. start picture-in-picture mode
4. double click on video in PIP mode
5. stop moving/clicking mouse, wait

Expected Behavior

the PIP controls should disappear after a few seconds so we can watch video undistracted

Actual Behavior

the PIP controls do not disappear and are over the video

Comment 1

[Peter deHaan [:pdehaan]]

:rbillings says:

Unable to confirm. On MacOS, the PIP controls display when the cursor is over the PIP window and disappear immediately once the cursor is moved away from the window.

Comment 2

[Romain Testard [:RT]]

I can reproduce by double clicking the PiP windows and bring the video full screen.
This is although not a regression and appears on release currently - I although agree that per full screen conventions the PiP controls should disappear in full screen.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This looks like a good first bug! I think the way to fix this is as follows:

1. Alter the rule here, so that it only matches if we're not in fullscreen. I think this should do it: body:not(:fullscreen) #controls:hover .control-item
2. We need to reveal the controls if we're in fullscreen and the mouse is moving. So add mousemove to the list here, and then handle that event just above here, and in that handler call this.onMouseMove(event);.
3. Create that method, onMouseMove that we're referring to in step (2), and have it first check if we're in fullscreen with "document.fullscreenElement == document.body". If that's not true, then bail out immediately. If it is true, then call this.revealControls(false) to reveal the controls on mouse movement.

I think that should do it for a fix!

Comment 5

[shirshak55]

Thanks, I would like to submit a fix for this. THanks

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Setting S4 because there is a workaround (move the mouse cursor to the edge of the screen).

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Sounds good! Thanks, shirshak55! Let me know if you have any questions on how to proceed.

Comment 8

[shirshak55]

Attachment: Bug 1707279 Fix picture-in-picture control do not always disappear r?mconley

Comment 9

[shirshak55]

@mconley

No question :) Thanks.

I am currently on Linux but I think windows and macOS users can check although I am sure it's cross platform so should work.

Comment 10

[shirshak55]

Attachment: Bug 1707279 Fix picture-in-picture control do not always disappear r?mconley

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/845af2530594
Fix picture-in-picture control do not always disappear r=mconley

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/845af2530594