1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[smow]

Attachment: Peek 2022-03-06 01-40.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

I downloaded a few files and later I tried to remove the last one displayed in the downloads panel.

Actual results:

Even though I selected the last one and clicked "Remove From History", the first one listed was removed.

Expected results:

The entry I selected should get removed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

I can also reproduce this on Win11 running the latest Nightly build, today's.

Comment 3

[Negritas Sergiu, Desktop QA]

Hello I have managed to reproduce the issue only with 99.0a1 (2022-03-07) on Ubuntu 20.04, with the firefox versions 98.0 and 97.0.2 the issue did not reproduce, I have also tried to reproduce on macOS 12 and windows 10 but i didn't manage with firefox 99.0a1(2022-03-07) and 97.0.2.

Marking this issue as new in order for our developers to look more into it.

Comment 4

[Julien Cristau [:jcristau]]

Any chance you can use mozregression to narrow it down further?

Comment 5

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=92c286a2adf98e61802ff7a5de2dd10609959d0a&tochange=2375d7340e84f802ed98fa68289153e036c63b63

Comment 6

[Julien Cristau [:jcristau]]

Thanks!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1756113

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1756113, could you take a look?
For more information, please visit auto_nag documentation.

Comment 10

[:Gijs (he/him)]

This is pretty bad and we should not ship this.

Comment 11

[Donal Meehan [:dmeehan]]

Are there any concerns in fixing this for 99?
Can this be assigned?

Comment 12

[James Graham [:jgraham]]

Dao: Do we have an update here? We need to get a patch asap to avoid shipping this in 99.

Comment 13

[Dão Gottwald [:dao]]

Attachment: Bug 1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6700f8451269
Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 9269396 [details]
Bug 1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0 and bug 1758644; we should test all context menu items.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed:

Comment 16

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6700f8451269

Comment 17

[Donal Meehan [:dmeehan]]

Hit a merge conflict in browser_downloads_panel_context_menu.js when trying to graft this to beta.
Please provide a patch with the merge conflicts resolved.

Comment 18

[Dão Gottwald [:dao]]

Attachment: patch for beta

fixed conflict in browser_downloads_panel_context_menu.js

Comment 19

[Donal Meehan [:dmeehan]]

Comment on attachment 9269396 [details]
Bug 1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak

Approved for beta uplift, available on the beta channel with 99RC1. Thanks.

Comment 20

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/555a349901bd

Comment 21

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 99.0a1 (20220306190604) on Windows 10x64 and Ubuntu 20. The first item is deleted when selecting the Remove from history context menu option on another item.

The issue is verified fixed with Firefox 100.0a1 (20220327213550) and 99.0b9 (20220327183628) from comment 20 on Windows 10x64/ 11x64, macOS 10.15 on Ubuntu 20. Selecting the Remove From History context menu option deletes the expected item from the Download Panel.

All the remaining context menu items were tested and they work as follows:

• Always Open Similar files- automatically open similar downloaded files when checked.
• Show in folder- opens the Explorer with the selected item in focus
• Go to Download Page- opens the webpage from where the item was downloaded.
• Delete- deletes the selected file from the explorer only
• Remove From History- successfully removes the selected item from the download panel
• Clear Preview Panel- clears all download panel