1762723 - Always first item drag & dropped from downloads list

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[tomaz.jandrok]

Attachment: bug.JPG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

1. I downloaded all STL files from this sample project
   https://www.thingiverse.com/thing:5323499/files

2. When I try to drag & drop the files visible in last downloaded list (not show all downloads) for example to Cura, there is always first downloaded file that is drag & dropped to the Cura (see attachment, where I tried to drag&drop third item in the list. It's the same with second item.).

Actual results:

When I drag & drop any downloaded file from last downloaded files list, first file from the list is always selected & drag & dropped to external program.

Expected results:

If I drag & drop for example second file in the last downloaded files list that should be drag & dropped to external program.

Comment 1

[:Gijs (out for now; he/him)]

Thanks for the report. This looks very similar to bug 1758294. Dão, can you take a look?

Reporter: are you seeing the same thing on more recent versions of beta? (I'm assuming you're on beta...)

Also, to confirm, if you use the library window (show all downloads - ctrl-j on Windows), does dragging from there work correctly?

Comment 2

[tomaz.jandrok]

I am testing this on beta version 99.0b (released on 8th of March), which is the latest currently on the Firefox website.
If I use library window (show all downloads) drag & drop functionality works correct as expected.
The bug can also be simply seen with just drag & dropping a file from last downloaded list to any folder in explorer on Windows (no external program needed).

Comment 3

[Marco Bonardo [:mak]]

it's likely a similar issue indeed, we drag the RLB selected item https://searchfox.org/mozilla-central/rev/26a1b0fce12e6dd495a954c542bb1e7bd6e0d548/browser/components/downloads/content/downloads.js#1045-1046 instead we should probably drag the closest download

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1762723 - Use proper dragstart event targets in the download panel. r=mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14a9df1615c5
Use proper dragstart event targets in the download panel. r=mak

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1756113

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/14a9df1615c5

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 9270746 [details]
Bug 1762723 - Use proper dragstart event targets in the download panel. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0; note that you don't need to drop the download on an external application, the tab bar works too for instance.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed:

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9270746 [details]
Bug 1762723 - Use proper dragstart event targets in the download panel. r=mak

Approved for 100.0b3

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fd0cfadfc29

Comment 11

[Anca Soncutean, Desktop QA]

Reproduced with Fx 100.0a1 (2022-04-02) (64-bit) on Windows 10.
Verified fixed with Fx 101.0a1 (2022-04-07) and Fx 100.0b3 on Windows 10, macOS 11.0 and Ubuntu 20.04.

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9270746 [details]
Bug 1762723 - Use proper dragstart event targets in the download panel. r=mak

Approved for 99.0.1.

Comment 14

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-release/rev/84fadca9092a

Comment 15

[Anca Soncutean, Desktop QA]

Verified fixed with FX 99.0.1 on Windows 10, macOS 11.0 and Ubuntu 20.04.