1759248 - Can't run puppeteer tests at all on Windows if node+npm are not in path - RuntimeError: Process hasn't been started yet

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P3)

Description

[:Gijs (he/him)]

As noted in bug 1753861, the tests don't run at all:

['npm', 'install']
Error running mach:

    ['puppeteer-test']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file puppeteer-test| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

RuntimeError: Process hasn't been started yet

  File "remote\mach_commands.py", line 660, in puppeteer_test
    install_puppeteer(command_context, product, ci)
  File "remote\mach_commands.py", line 704, in install_puppeteer
    npm(command, cwd=os.path.join(command_context.topsrcdir, puppeteer_dir), env=env)
  File "remote\mach_commands.py", line 214, in npm
    wait_proc(p, cmd="npm", exit_on_fail=kwargs.get("exit_on_fail", True))
  File "remote\mach_commands.py", line 227, in wait_proc
    p.kill()
  File "testing\mozbase\mozprocess\mozprocess\processhandler.py", line 973, in kill
    raise RuntimeError("Process hasn't been started yet")

Sentry event ID: b05a925c50d14e5dbc94de573a28ab77
Sentry is attempting to send 0 pending error messages

Manually npm install ing the tests also doesn't seem to help, it just tries to install them some more (despite testing on today's m-c, so it should have bug 1757523, but I guess I have to manually pass extra arguments to make the command not waste time? That seems counter-intuitive to say the least.

Comment 1

[:Gijs (he/him)]

Something like this makes the install step work: https://paste.mozilla.org/BwizvKcb

But still breaks when attempting to actually run tests.

Tooling in m-c should be using the mozbuild npm/node paths and not rely on other ones or we'll just see version mismatches, surely?

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1759248 - don't mess up paths for npm/node on Windows when running puppeteer tests, r?whimboo,jgraham

Comment 3

[:Gijs (he/him)]

Bah, it's because of https://searchfox.org/mozilla-central/rev/c3894603d85d2e45dbebf9697f1951ab998b22cb/remote/mach_commands.py#50 which tries to help but fails

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f6b40d63b43
don't mess up paths for npm/node on Windows when running puppeteer tests, r=whimboo,jgraham,webdriver-reviewers

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7f6b40d63b43