175925 - You can't right-align the bookmark toolbar on the menu toolbar

Status: REOPENED

(Firefox :: Toolbars and Customization, defect)

Description

[Todd Boland]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021021 Phoenix/0.3

This minor bug is more of a nuisance than a bug. To reproduce:

TO REPRODUCE:

Make sure you have only a few bookmarks which have short names to see the
result. I have four bookmarks with their name's blank so I only see their favicons.

1. View->Toolbars->Customize...
2. Drag some flexible space to the right of the menus on the menu toolbar (top one)
3. Drag the Bookmark toolbar up to the right of the flexible space
4. Press Done

ACTUAL RESULT:
The bookmarks are not flushly aligned to the right. They appear to be center
justified in the black area left in the menubar.

EXPECTED RESULT:
THe bookmarks should be aligned to the right and be flush with the ende of the
toolbar.

Comment 1

[Todd Boland]

Attachment: Example of behavior

Comment 2

[Todd Boland]

Attachment: The example.

Comment 3

[David Tenser [:djst]]

Confirming on Windows XP build
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021021 Phoenix/0.3

Comment 4

[Tuukka Tolvanen (sp3000)]

*** Bug 178868 has been marked as a duplicate of this bug. ***

Comment 5

[Blake Ross]

worksforme.

Comment 6

[Blake Ross]

noririty says he still sees this.  If anyone has a patch for this, that'd be great.

Comment 7

[basic]

my guess the issue here is that the bookmarks toolbar flex, that is why it
behaves the way it does. I'm wondering what effect it will have if we remove the
flex...

Comment 8

[basic]

Attachment: remove flex="1"

this patch removes flex="1" from the personal bookmarks toolbar item. Seems to
fix the issue. Probably needs more testing.

Comment 9

[basic]

Attachment: patch v2 (remove flex="1" from stack as well)

this patch seems to work better.

Comment 10

[basic]

Comment on attachment 128618 [details] [diff] [review]
patch v2 (remove flex="1" from stack as well)

ok my bad it was just bookmarks toolbar width sizing issues (related to bug
174390), nothing to do with the flex. The first patch is good.

Comment 11

[basic]

with the patch in bug 174390 this works fairly well, review?

Comment 12

[noririty]

Comment on attachment 128571 [details] [diff] [review]
remove flex="1"

r=noririty

Comment 13

[noririty]

checked in

Comment 14

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

This bug caused bug 215383. That bug is far worse than this one. I've backed out
this patch. 

Comment 16

[Wayne Mery (:wsmwk)]

not relevant given that bookmark toolbar can't exist on other lines

Comment 17

[David Tenser [:djst]]

(In reply to comment #16)
> not relevant given that bookmark toolbar can't exist on other lines
> 

This bug is either FIXED or WONTFIX. The bug still exists as described, and yes, the toolbar can exist next to the menu.

-> Reopen

Comment 18

[buovjaga]

The bookmark toolbar can't be put in line with the menu anymore, so let's close as WONTFIX.

Comment 19

[:Gijs (he/him)]

(In reply to buovjaga from comment #18)
> The bookmark toolbar can't be put in line with the menu anymore, so let's
> close as WONTFIX.

You can still put the bookmark toolbar items on the menubar using customize mode.

Comment 20

[buovjaga]

Eh, sorry for the noise.. I overlooked that one has to first set the menubar as visible.