1759741 - Allow importing devtools/client/shared/test/shared-head.js from xpcshell tests

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The main test helper file:
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/shared-head.js
is only used by browser mochitest.
While it can't be used as-is from an xpcshell test. Various code throw when doing so as we depend on various symbols/components that only work from the mochitest environment.

This is a bit unfortunate as it prevent easily reuse the exact same test helpers between xpcshell and mochitests.

For example waitForDispatch is having three copies:
https://searchfox.org/mozilla-central/search?q=function+waitForDispatch%28&path=devtools%2F&case=true&regexp=false
We have one copy dedicated to one xpcshell test folder:
devtools/client/memory/test/xpcshell/head.js
Another one dedicated to mochitest:
devtools/client/shared/test/shared-head.js
And this last one used from both:
devtools/client/shared/test/shared-redux-head.js

If xpcshell was able to import shared-head, then we could have only one copy of this method.
There is probably many other functions being duplicated...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759741 - [devtools] Start using shared-head by a first xpcshell test.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759741 - [devtools] Remove shared-redux-head being redundant with shared-head.js

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b14b71a829f
[devtools] Start using shared-head by a first xpcshell test. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/31b601063d06
[devtools] Remove shared-redux-head being redundant with shared-head.js r=jdescottes

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6b14b71a829f
https://hg.mozilla.org/mozilla-central/rev/31b601063d06