1759822 - Cleanup shared-head from test helpers used only by one test or one folder

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

There is a few methods in shared-head that are only used by one test or one test folder.
They should be moved.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759822 - [devtools] Move getSupportedToolIds to framework test helper.

As this is only used by this folder.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759822 - [devtools] Move lookupPath to helper_markup_accessibility_navigation.js.

As that's the only place where it is used.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759822 - [devtools] Move waitForTitleChange to the one test using this.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759822 - [devtools] Use shared waitUntilScreenshot method.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759822 - [devtools] Move checkPoolChildrenSize to the one test using this helper.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1759822 - [devtools] Group to the top of shared-head all intructions before all function definitions.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb3c457b37a9
[devtools] Move getSupportedToolIds to framework test helper. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/68c89e5d9e40
[devtools] Move lookupPath to helper_markup_accessibility_navigation.js. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/ad4e7cd03ba2
[devtools] Move waitForTitleChange to the one test using this. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/e9a3634b57ca
[devtools] Use shared waitUntilScreenshot method. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/1b85282bc405
[devtools] Move checkPoolChildrenSize to the one test using this helper. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/12cd729f8185
[devtools] Group to the top of shared-head all intructions before all function definitions. r=jdescottes

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/eb3c457b37a9
https://hg.mozilla.org/mozilla-central/rev/68c89e5d9e40
https://hg.mozilla.org/mozilla-central/rev/ad4e7cd03ba2
https://hg.mozilla.org/mozilla-central/rev/e9a3634b57ca
https://hg.mozilla.org/mozilla-central/rev/1b85282bc405
https://hg.mozilla.org/mozilla-central/rev/12cd729f8185