1759857 - The Best Match result keeps the fade effect after maximizing the browser if previously the browser was resized to a reduced width

Status: NEW

(Firefox :: Address Bar, defect, P3)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Nightly 100.0a1, Build ID: 20220315213924
• Firefox Beta 99.0b4, Build ID: 20220315185755

[Affected platforms]:

• macOS 11.6.3
• Windows 10 x64
• Ubuntu 20 x64

[Prerequisites]:

• Have the browser.urlbar.bestMatch.enabled pref set to true.
• Have the browser.search.region pref set to US.

[Steps to reproduce]:

1. Open the browser profile.
2. Focus the Address bar and write at least 4 characters of a string that would trigger a sponsored/non-sponsored result within the Top pick section (eg:xbox, keyboards, microwaves, apple, disney, betty etc).
3. Resize the width of the browser to minimum.
4. Click the browser’s “Maximize” button.
5. Click inside the Address Bar and observe the Best Match result.

[Expected result]:

• The Best Match result is displayed correctly and fully visible.

[Actual result]:

• The Best Match result keeps the fade effect at the end of the keyword.

[Notes]:

• Here is a screen recording of the issue.

Comment 1

[Maria Heres, inactive, contact Ecosystem QA]

The opposite of this behavior was observed using Firefox Beta 99.0b6 (Build ID: 20220320185956) on Linux Mint 20.2.

• The fade effect no longer works if the result was first observed in a maximized window which is then resized to a smaller size.

You can find a recording here.

Comment 2

[Drew Willcoxon :adw]

The first problem happens for all rows, not only best match, so I think that deprioritizes this a little bit in terms of ongoing Suggest work. These are the STR I'm using:

1. Visit https://support.mozilla.org/en-US/kb/firefox-suggest?as=u&utm_source=inproduct
2. Open a new tab and close the tab from step 1
3. Make the window as narrow as possible
4. Type how to, verify the visit from step 1 appears
5. Press Esc to close the panel
6. Make the window very wide. It needs to be wide enough so there's enough space to fully show the title and URL of the visit row in the next step
7. Click in the urlbar to show the panel again

At that point, the URL of the visit row should be fully visible without a fade, and the title will have an unnecessary fade out effect.

I couldn't reproduce the problem in comment 1 with other rows.

Comment 3

[Drew Willcoxon :adw]

I'm not currently working on this, unassigning.

Comment 5

[Marco Bonardo [:mak]]

I think the problem at hand is that in certain cases we have stuck "overflow" attributes on the results. And because we reuse DOM Elements, those are stuck with the new values too.
We should, at a certain point, remove all the "overflow" attributes when the window is resized, even if the view is closed, and/or do that when we reuse dom elements in the view.

Comment 6

[Drew Willcoxon :adw]

This was fixed by bug 1815686.