1759890 - resolve typing issues in Lando

Status: RESOLVED FIXED

(Conduit :: Lando, task, P5)

Description

[Connor Sheehan [:sheehan]]

Lando has quite a few instances of incorrect or inconsistent uses of Python's gradual typing feature. For example setting a value as name: type = None, and then always using the variable without doing a None-check. We should resolve these typing issues as appropriate.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: GitHub Pull Request

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: GitHub Pull Request

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: GitHub Pull Request

Comment 4

[Connor Sheehan [:sheehan]]

Attachment: GitHub Pull Request

Comment 5

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] landing_worker: make `sleep_seconds` a float (Bug 1759890) (#227)

Comment 6

[Connor Sheehan [:sheehan]]

Attachment: GitHub Pull Request

Comment 7

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: set `scopes` type to `Iterable` (Bug 1759890) (#232)

Comment 8

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: add hints and clarify types in various places (Bug 1759890) (#234)

Comment 9

[BMO Automation]

Comment on attachment 9304515 [details] [review]
[mozilla-conduit/lando-api] landing_worker: make sleep_seconds a float (Bug 1759890) (#227)

GitHub pull request attachment was moved to bug 1717806. Setting attachment 9304515 [details] [review] to obsolete.

Comment 10

[BMO Automation]

Comment on attachment 9305617 [details] [review]
[mozilla-conduit/lando-api] typing: add hints and clarify types in various places (Bug 1759890) (#234)

GitHub pull request attachment was moved to bug 1800700. Setting attachment 9305617 [details] [review] to obsolete.

Comment 11

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] phabricator: remove `g.phabricator` and replace with arguments to command function (Bug 1759890) (#236)

Comment 12

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: add/clarify type hints in several places (Bug 1759890) (#237)

Comment 13

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] testing: pass arguments as sets in `test_stacks.py` (Bug 1759890) (#245)

Comment 14

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: fix a few typing issues (Bug 1759890) (#252)

Comment 15

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: finish adding types for `api/transplants.py` (Bug 1759890) (#255)

Comment 16

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] patches: add type hints everywhere (Bug 1759890) (#258)

Comment 17

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] phabricator: add type hints and remove some unused code (Bug 1759890) (#259)

Comment 18

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: finish adding type hints to `landoapi/{api,models}` (Bug 1759890) (#261)

Comment 19

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: remove `typing.{Dict,List,Set,Tuple,Union}` and use builtins directly (Bug 1759890) (#262)

Comment 20

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: add missing types to `auth.py` and `cli.py` (Bug 1759890) (#263)

Comment 21

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] uplift: check `target_repo` for `None` (Bug 1759890) (#265)

Comment 22

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] landing_worker: use `ConfigurationKey` instead of string variable (Bug 1759890) (#268)

Comment 23

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] transplants: separate `None` check for required variables (Bug 1759890) (#269)

Comment 24

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] projects: clarify that `get_release_managers` returns an `Optional` (Bug 1759890) (#270)

Comment 25

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] types: add type hints to `secapproval.py`, `sentry.py`, `transplant_client.py` (Bug 1759890) (#271)

Comment 26

[BMO Automation]

Attachment: [mozilla-conduit/lando-api] typing: add type hints to `repos.py`, `revisions.py` (Bug 1759890) (#273)

Comment 27

[BMO Automation]

Attachment: [mozilla-conduit/lando-ui] typing: add type hints to `template_helpers.py` and `usersettings.py` (Bug 1759890) (#159)

Comment 28

[BMO Automation]

Attachment: [mozilla-conduit/lando-ui] stack: add type hints to stack functions (Bug 1759890) (#161)

Comment 29

[BMO Automation]

Attachment: [mozilla-conduit/lando-ui] typing: add type hints to `pages.py`, `revisions.py`, `sentry.py` (Bug 1759890) (#163)

Comment 30

[BMO Automation]

Attachment: [mozilla-conduit/lando-ui] typing: add type hints to `forms.py`, `helpers.py`, `landoapi.py` (Bug 1759890) (#164)

Comment 31

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] typing: clarify the type of `bug_ids` as `Iterable` (Bug 1759890) (#301)

Comment 32

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] typing: add types to `hgexports.py` and fix `set_patch` types (Bug 1759890) (#330)

Comment 33

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] landing_job: mark `repositories` as an `Iterable[str]` (Bug 1759890) (#333)

Comment 34

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-ui] typing: add type hints to `auth.py` (Bug 1759890) (#181)

Comment 35

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-ui] typing: add type hints to `app.py` (Bug 1759890) (#185)

Comment 36

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] landing-job: add a type hint to `revisions` (Bug 1759890) (#362)

Comment 37

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] typing: add type hints to `notifications.py` (Bug 1759890) (#371)

Comment 38

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] typing: add type hints to `logging.py` (Bug 1759890) (#378)

Comment 39

[Connor Sheehan [:sheehan]]

Closing this out as we have mostly completed adding type hints to Lando, have ruff checking for some annotations rules, and generally require type hints to be added for new code.