1760541 - Don't reuse longString actors

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

In createValueGrip (devtools/server/actors/object/utils.js#123), we check if a longString actor was already created for the passed string so we can reuse it.
This can be dangerous if multiple panels end up using the same fronts and one of the panel releases it while the other expect it to be alive.
It's also a performance issue as we're searching through all the created actors, and can take a while if we have lots of them.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1760541 - [devtools] Don't reuse longString actors for same string.r=ochameau.

Depends on D141573

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0c9fc3a8d87
[devtools] Don't reuse longString actors for same string.r=ochameau.

Comment 3

[Sandor Molnar]

Backed out 3 changesets (bug 1759666, bug 1760541, bug 1760540) for causing talos damp failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/270fdfb511cfab2286f4d52fdfde34bc762b7938

Push with failures

Failure log

 Start "console.log-in-loop-content-process-infinity"
[task 2022-03-22T20:50:29.552Z] 20:50:29     INFO -  PID 19227 | Garbage collect
[taskcluster:error] Aborting task...
[taskcluster:warn 2022-03-22T20:50:31.878Z] no such process

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01e704140fff
[devtools] Don't reuse longString actors for same string.r=ochameau.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

failure not caused by this patch

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/01e704140fff