1760633 - Update fdlibm and add *f functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tom Ritter [:tjr]]

We're fiddling with eliminating the webaudio fingerprint by using fdlibm math routines there; but there are many float-based functions missing from our in-tree copy of fdlibm.

This bug will track adding them.

Arai - I'm going to attach some phabricator patches that compile but shouldn't be reviewed (except beyond "Is it conceptually okay to add these functions/files"). When I have more time I'll reproduce them and create a set of patches that correctly modify the download/update script and the local patches we apply.

Comment 1

[Tom Ritter [:tjr]]

Attachment: WIP: Bug 1760633: Update fdlibm

Comment 2

[Tom Ritter [:tjr]]

Attachment: WIP: Bug 1760633: Add new fdlibm files

Depends on D141639

Comment 3

[Tom Ritter [:tjr]]

Attachment: WIP: Bug 1760633: header commenting

Depends on D141640

Comment 4

[Tom Ritter [:tjr]]

Attachment: WIP: Bug 1760633: file include renaming

Depends on D141641

Comment 5

[Tom Ritter [:tjr]]

Attachment: WIP: Bug 1760633: Remove an unused function in k_expf

Depends on D141642

Comment 6

[Tom Ritter [:tjr]]

This compiles on Linux; but not on Windows due to expf having a duplicate symbol...

Comment 7

[Tom Ritter [:tjr]]

Attachment: WIP: Bug 1760633: comment out __weak_reference

Comment 8

[Tom Ritter [:tjr]]

Attachment: Bug 1760633: Add new files to fdlibm's moz.yaml r?arai

Comment 9

[Tom Ritter [:tjr]]

Attachment: Bug 1760633: Update fdlibm patches to apply to new files r?arai

Depends on D164815

Comment 10

[Tom Ritter [:tjr]]

Attachment: Bug 1760633: Actually add the new fdlibm files and apply the patches r?arai

This applies the patches to the new files, but not the existing
in-tree files (fdlibm.h and math_private.h)

Depends on D164816

Comment 11

[Tom Ritter [:tjr]]

Attachment: Bug 1760633: Apply the fdlibm patches for the new files to the in-tree files r?arai

This updates our previously in-tree files to account for the
new files we added.

Depends on D164817

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5b0ccc77084
Add new files to fdlibm's moz.yaml r=arai

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a5b0ccc77084

Comment 15

[Tom Ritter [:tjr]]

Accidentally only landed the top patch instead of the bottom patch

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/addec3dc0f80
Update fdlibm patches to apply to new files r=arai
https://hg.mozilla.org/integration/autoland/rev/ee8ecdac4be5
Actually add the new fdlibm files and apply the patches r=arai
https://hg.mozilla.org/integration/autoland/rev/527f857a91f8
Apply the fdlibm patches for the new files to the in-tree files r=arai

Comment 17

[Serban Stanca [:SerbanS]]

Backed out for causing Spidermonkey bustages.

• Backout link

• Push with failures

• Failure Log

• Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:540: libmozjs-110a1.so] Error 1

• Also it failed like this: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=e1f3e1dc2ea2ab7089f15340095f4fd4d7173d1d&tochange=4f96e1e08cbf9b266e6c58c12ffa7374b473a8aa&selectedTaskRun=ORzp-ATHT-ua440kJgbs2w.0

• Failure Log

• Failure line: subprocess.CalledProcessError: Command '['sh', '-c', "'C:/mozilla-build/python3/python3.exe' 'Z:/task_167301756105572/src/mach' build"]' returned non-zero exit status 2.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea0c39428939
Update fdlibm patches to apply to new files r=arai
https://hg.mozilla.org/integration/autoland/rev/aca1820b62a2
Actually add the new fdlibm files and apply the patches r=arai
https://hg.mozilla.org/integration/autoland/rev/2211f048d689
Apply the fdlibm patches for the new files to the in-tree files r=arai

Comment 19

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ea0c39428939
https://hg.mozilla.org/mozilla-central/rev/aca1820b62a2
https://hg.mozilla.org/mozilla-central/rev/2211f048d689