Update fdlibm and add *f functions
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox110 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(4 files, 6 obsolete files)
We're fiddling with eliminating the webaudio fingerprint by using fdlibm math routines there; but there are many float-based functions missing from our in-tree copy of fdlibm.
This bug will track adding them.
Arai - I'm going to attach some phabricator patches that compile but shouldn't be reviewed (except beyond "Is it conceptually okay to add these functions/files"). When I have more time I'll reproduce them and create a set of patches that correctly modify the download/update script and the local patches we apply.
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Depends on D141639
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D141640
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D141641
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D141642
Assignee | ||
Comment 6•2 years ago
|
||
This compiles on Linux; but not on Windows due to expf having a duplicate symbol...
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 7•2 years ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Comment 8•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Comment 9•1 year ago
|
||
Depends on D164815
Assignee | ||
Comment 10•1 year ago
|
||
This applies the patches to the new files, but not the existing
in-tree files (fdlibm.h and math_private.h)
Depends on D164816
Assignee | ||
Comment 11•1 year ago
|
||
This updates our previously in-tree files to account for the
new files we added.
Depends on D164817
Comment 12•1 year ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Updated•1 year ago
|
Comment 13•1 year ago
|
||
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5b0ccc77084 Add new files to fdlibm's moz.yaml r=arai
Comment 14•1 year ago
|
||
bugherder |
Assignee | ||
Comment 15•1 year ago
|
||
Accidentally only landed the top patch instead of the bottom patch
Comment 16•1 year ago
|
||
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/addec3dc0f80 Update fdlibm patches to apply to new files r=arai https://hg.mozilla.org/integration/autoland/rev/ee8ecdac4be5 Actually add the new fdlibm files and apply the patches r=arai https://hg.mozilla.org/integration/autoland/rev/527f857a91f8 Apply the fdlibm patches for the new files to the in-tree files r=arai
Comment 17•1 year ago
|
||
Backed out for causing Spidermonkey bustages.
-
Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:540: libmozjs-110a1.so] Error 1
-
Failure line: subprocess.CalledProcessError: Command '['sh', '-c', "'C:/mozilla-build/python3/python3.exe' 'Z:/task_167301756105572/src/mach' build"]' returned non-zero exit status 2.
Updated•1 year ago
|
Comment 18•1 year ago
|
||
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea0c39428939 Update fdlibm patches to apply to new files r=arai https://hg.mozilla.org/integration/autoland/rev/aca1820b62a2 Actually add the new fdlibm files and apply the patches r=arai https://hg.mozilla.org/integration/autoland/rev/2211f048d689 Apply the fdlibm patches for the new files to the in-tree files r=arai
Comment 19•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea0c39428939
https://hg.mozilla.org/mozilla-central/rev/aca1820b62a2
https://hg.mozilla.org/mozilla-central/rev/2211f048d689
Assignee | ||
Updated•1 year ago
|
Description
•