1804298 - Make fdlibm vendorable by mach vendor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Tom Ritter [:tjr]]

We are trying to add an informative moz.yaml file for all third party code in Firefox. Optionally, this file can include (machine-read) instructions for vendoring a new update of the library in. (This typically replaces existing in-tree scripts.)

With those instructions, we can also have Updatebot look for upstream changes and automatically detect them and file a bug, send to try, attach a patch, etc.

In order to make Bug 1760633 much easier, I'd like to make fdlibm vendorable with mach vendor.

You would run ./mach vendor modules/fdlibm/moz.yaml to perform the update. Because fdlibm has patches you'd first run ./mach vendor modules/fdlibm/moz.yaml --patch-mode=none, commit that, and then ./mach vendor modules/fdlibm/moz.yaml --patch-mode=only to apply the patches, and then commit that. If the patches need updating, that command will fail and you can manually change the files and update the patch files so it will work next time.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1804298: mach vendor Fixes/Minor Improvements r?andi

• make sure the patch files are sorted before we apply them
• strip trailing slashes from the repo url before we add more
• Allow the individual-files action to be used by individual-files

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1804298: mach vendor support for an alternate, more terse way of individual-files r?andi

If we want to use individual-files for a lot of files, all
of which are going the same place, it is very verbose and
repetitive. Create an alternate, mutually-exclusive way of
specifying individual-files in a moz.yaml

Depends on D163968

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1804298: Add a moz.yaml for fdlibm and make it vendor-able r?arai

Remove the old update scripts so we can use ./mach vendor
to vendor it.

Depends on D163969

Comment 4

[Tom Ritter [:tjr]]

Attachment: Bug 1804298: Update the fdlibm patches to be vendored by mach vendor r?arai

For mach vendor, patches are relative to the directory the
third party code is vendored into.

Depends on D163970

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16e0b1dd9ea3
mach vendor Fixes/Minor Improvements r=andi
https://hg.mozilla.org/integration/autoland/rev/10959074fd6b
mach vendor support for an alternate, more terse way of individual-files r=andi
https://hg.mozilla.org/integration/autoland/rev/1750fca4189b
Add a moz.yaml for fdlibm and make it vendor-able r=arai
https://hg.mozilla.org/integration/autoland/rev/abf7ce069748
Update the fdlibm patches to be vendored by mach vendor r=arai

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/16e0b1dd9ea3
https://hg.mozilla.org/mozilla-central/rev/10959074fd6b
https://hg.mozilla.org/mozilla-central/rev/1750fca4189b
https://hg.mozilla.org/mozilla-central/rev/abf7ce069748