<a class="header-button" href="https://bugzilla.mozilla.org/home" title="Go to home page"> Bugzilla

Comment 4

•

3 years ago

This is a pretty generic crash signature. The exception reason I see in Nightly 106 (UnsupportedOperationException: This isn't a hierarchical URI) is different from that in comment 0 (IllegalArgumentException: Tab with same ID already exists).

...
Caused by: java.lang.UnsupportedOperationException: This isn't a hierarchical URI.
	at android.net.Uri.getQueryParameterNames(Uri.java:1616)
	at org.mozilla.fenix.ext.UriKt.containsQueryParameters(Uri.kt:4)
	at org.mozilla.fenix.home.blocklist.BlocklistHandler.filterContileRecentTab(BlocklistHandler.kt:8)
	at org.mozilla.fenix.home.blocklist.BlocklistMiddleware.invoke(BlocklistMiddleware.kt:20)
	at mozilla.components.lib.state.internal.ReducerChainBuilder$build$1$1.invoke(ReducerChainBuilder.kt:3)
	at mozilla.components.lib.state.internal.ReducerChainBuilder$build$threadCheck$1.invoke(ReducerChainBuilder.kt:10)
	at mozilla.components.lib.state.internal.ReducerChainBuilder$build$1$1.invoke(ReducerChainBuilder.kt:3)
	at mozilla.components.lib.state.Store$dispatch$1.invokeSuspend(Store.kt:4)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:4)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:18)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:920)

Crash Signature: [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java)] → [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java)] [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(Unknown Source:35)] [@ java.lang.RuntimeExcept…

status-firefox104: --- → affected

status-firefox105: --- → ?

Flags: needinfo?(cpeterson)

Priority: -- → P1

Ryan VanderMeulen [:RyanVM]

Comment 5

•

3 years ago

The most recent crashing build ID is 20220901095452, so this crash does seem to have been fixed in Nightly last week. Noah says this crash was fixed by https://github.com/mozilla-mobile/fenix/issues/26759.

Status: NEW → RESOLVED

Closed: 3 years ago

status-firefox105: ? → unaffected

status-firefox106: affected → fixed

Resolution: --- → FIXED

See Also: → https://github.com/mozilla-mobile/fenix/issues/26759

Comment 6

•

3 years ago

We may have fixed the spike on Nightly, but this bug pre-dates that specific issue. We probably should have opened a new bug to track that specific regression.

Status: RESOLVED → REOPENED

status-firefox104: affected → wontfix

status-firefox105: unaffected → wontfix

status-firefox106: fixed → affected

tracking-firefox106: + → ---

Resolution: FIXED → ---

Updated

•

3 years ago

Priority: P1 → P2

Updated

•

3 years ago

Component: Stability → General

Updated

•

3 years ago

status-firefox107: --- → affected

status-firefox108: --- → affected

Priority: P2 → P3

BMO Automation

Updated

•

2 years ago

Crash Signature: [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java)] [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(Unknown Source:35)] [@ java.lang.RuntimeExcept… → [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run] [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run] [@ java.lang.RuntimeException: at com.android.internal.os.Runti…

Summary: Crash in [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java)] in java.lang.IllegalArgumentException: Tab with same ID already exists → Crash in [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run] in java.lang.IllegalArgumentException: Tab with same ID already exists

Updated

•

2 years ago

Crash Signature: [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run] [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run] [@ java.lang.RuntimeException: at com.android.internal.os.Runti… → [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java)] [@ java.lang.RuntimeException: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(Unknown Source:35)] [@ java.lang.RuntimeExcept…

status-firefox110: --- → affected

status-firefox111: --- → affected

status-firefox112: --- → affected

Updated

•

2 years ago

Comment 7

•

1 year ago

I recently encountered this error.

Flags: needinfo?(cpeterson)

Comment 8

•

1 year ago

I saw this error in the category: History, under: Recently closed tabs. I clicked on a link in recently closed files and can reproduce the error over and over, in all versions.

Comment 9

•

1 year ago

Attached video mobizen_20240322_011406.mp4 — Details

Comment 10

•

1 year ago

(In reply to eclaudiu64 from comment #8)

I saw this error in the category: History, under: Recently closed tabs. I clicked on a link in recently closed files and can reproduce the error over and over, in all versions.

Thanks for the steps to reproduce and video!

Do you have a crash report ID listed in your Firefox's about:crashes?

Severity: S2 → --

status-firefox124: --- → affected

status-firefox125: --- → affected

status-firefox126: --- → ?

Component: General → Tabs

Flags: needinfo?(cpeterson)

Keywords: reproducible

Priority: P3 → --

https://crash-stats.mozilla.org/report/index/e9bd8942-0390-44e1-9b3e-bf1980240321

Comment 11

•

1 year ago

Attached image Screenshot_20240322-111759_Firefox Beta.jpg — Details

Flags: needinfo?(cpeterson)

Comment 12

•

1 year ago

Thanks! This crash bug is old, but it's still in our top #30 crashes. We've never been able to reproduce it before.

Flags: needinfo?(cpeterson)

Ryan VanderMeulen [:RyanVM]

Comment 13

•

1 year ago

(In reply to Chris Peterson [:cpeterson] from comment #12)

Thanks! This crash bug is old, but it's still in our top #30 crashes. We've never been able to reproduce it before.

Much more attention should be paid to this error, as far as I can see it affects a user a lot. After reproducing the error, from the category: History, that error can be repeated again, if it remains the same site, in the same place in the list and we press it again.

Updated

•

1 year ago

status-firefox106: affected → wontfix

status-firefox107: affected → wontfix

status-firefox108: affected → wontfix

status-firefox110: affected → wontfix

status-firefox111: affected → wontfix

status-firefox112: affected → wontfix

status-firefox126: ? → affected

Rahul Sainani [:rsainani]

Updated

•

1 year ago

Severity: -- → S2

Priority: -- → P2

Whiteboard: [fxdroid] [group4]

Jira Integration Bot

Updated

•

1 year ago

See Also: → https://mozilla-hub.atlassian.net/browse/FXDROID-1697

BugBot [:suhaib / :marco/ :calixte]

Comment 14

•

1 year ago

The bug is linked to a topcrash signature, which matches the following criteria:

Top 10 AArch64 and ARM crashes on beta
Top 10 AArch64 and ARM crashes on release

For more information, please visit BugBot documentation.

Keywords: topcrash

Comment 15

•

1 year ago

Attached video mobizen_20240401_142029.mp4 — Details

This error remains every time stuck on the same link, when I access: History and after Last tabs closed and you can see how bad it is. Can it be solved?

Flags: needinfo?(cpeterson)

https://crash-stats.mozilla.org/report/index/a3208deb-0efa-453f-944a-c97570240401

Comment 16

•

1 year ago

In the recording, Firefox seems to be surprised that opening a page from History matches an existing open tab, but I'm not able to reproduce the History crash on my device.

This crash signature is generic signature with many causes, but here's an example of a crash report for this same IllegalArgumentException: Tab with same ID already exists error:

From this code:

https://searchfox.org/mozilla-central/rev/10f46c9c638e0e5935ed9fa12aadc9d0d4e71ade/mobile/android/android-components/components/browser/state/src/main/java/mozilla/components/browser/state/reducer/TabListReducer.kt#332

If this code requires a unique tab, can we create a new tab if the Tab ID already exists, instead of crashing the app?

/**
 * Checks that the provided tab doesn't already exist and throws an
 * [IllegalArgumentException] otherwise.
 *
 * @param state the current [BrowserState] (including all existing tabs).
 * @param tab the [TabSessionState] to check.
 */
private fun requireUniqueTab(state: BrowserState, tab: TabSessionState) {
    require(state.tabs.find { it.id == tab.id } == null) {
        "Tab with same ID already exists"
    }
}

Flags: needinfo?(cpeterson)

Comment 17

•

1 year ago

•

Edited

Tried opening tabs from the Recently Closed Tabs (from both the 3 dot menu and the tabs tray) and didn't see the Tab with same ID already exists exception or any crashes. Once the tab has been opened, it's also removed from the Recently Closed list, so I don't occur the issue with the same link over and over.

Would QE be able to produce some STR?

Mira Lobontiu (Android QA)

Updated

•

1 year ago

Flags: qe-verify+

Comment 18

•

1 year ago

Unfortunately, I was not able to trigger a crash by following Claudiu's steps. I was not able to trigger it with the fingerprint scenario either.
Tested on Samsung Galaxy Note 8 (Android 9), Google Pixel 6 (Android 14), Samsung Galaxy A14 (Android 13), and Oppo Find N2 Flip (Android 14), on Firefox for Android 125.3.0, Nightly 127.0a1 from 5/10.

Flags: qe-verify+

Noah Bond [:007]

Comment 19

•

1 year ago

I spent a couple hours today looking into this. I haven't been able to reproduce it, but I do have some hypotheses:

Race condition between closing a tab and restoring it
- The tab has not been removed from browser state by the time restoration happens
Statistical anomaly
- UUIDs are somehow being repeated
  - 128bits, so this seems insanely unlikely
2+ TabListReducer.RestoreActions are being dispatched
A closed tab is somehow getting the data of an open tab
A closed tab is still living within browser state when it is being restored.

I would suggest for some next steps to be either adding some more breadcrumbs to the browser store actions and recently closed flow OR provide an APK here with an over abundance of logging inside of:

TabListReducer.RestoreAction
TabListReducer.requireUniqueTab (make sure that the tabs are actually the same and it isn't just the tab ID)
Tab restore and remove use cases
Tab ID creation (UUID generation)
Browser store (log the actions as they flow through the reducer)
Reducer state updates to BrowserState.tabs and BrowserState.closedTabs

BugBot [:suhaib / :marco/ :calixte]

Comment 20

•

1 year ago

•

Edited

We will provide an APK with additional logging.

Flags: needinfo?(emanuellclaudiu)

Comment 21

•

1 year ago

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit BugBot documentation.

Keywords: topcrash

Noah Bond [:007]

Comment 22

•

1 year ago

•

Edited

Attached file App Bundle with logs — Details

I've created and attached an app bundle with a bunch of logging to help with the debugging of this crash. If anyone who has faced this issue could please download and install it and share the logs in the ticket when the crash happens next, it'd greatly assist us with trying to diagnose the issue.

Nicholas Poon [:Nick]

Updated

•

1 year ago

Updated

•

1 year ago

Comment 23

•

1 year ago

Dear Ladies and Gentlepeople,

I think i might be affected by the bug described here:

See, among other crash-reports:
https://crash-stats.mozilla.org/report/index/ff2b712b-4ec7-4daa-83e9-9aef80240714#tab-details

Am able to reliably crash Firefox-Beta using my FP4.
If someone knowledgable can confirm my issue is related to the Bug described here, Then I'm happy to help with debugging (providing info/data).