1761238 - Title bar checkbox is barely visible with Alpenglow theme inside Customize menu

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: title_bar

Affected versions

• 100.0a1 (20220323214810)
• 99.0b7
• 98.0.2

Affected platforms

• Windows 10x64

Preconditions

• Windows dark theme selected

Steps to reproduce

1. Open Firefox and set the Alpenglow theme.
2. Open the Customize menu and observe the Title bar checkbox.

Expected result

• The checkbox is visible.

Actual result

• The checkbox is barely visible.

Regression range

• Last good revision: 340719f2946c85bb8df494cb4740129e5a5078af
  First bad revision: 6d22ab00f3133b6760ebca3943dba097eff853c7
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=340719f2946c85bb8df494cb4740129e5a5078af&tochange=6d22ab00f3133b6760ebca3943dba097eff853c7

Notes

• Screenshot attached.
• Not reproducible on Ubuntu 21 and macOS 12.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1734115, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

As far as I can tell, we are not using native colors here. This block makes the buttons light, but doesn't make the checkbox light and it probably should.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1761238 - Use ThreeDShadow rather than ThreeDDarkShadow on checkboxes by default. r=dao,Gijs

That works nicely for both light and dark mode.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

One additional step in the STR that's critical for testing - on Windows, you must set the "default app mode" for Colours to "Dark" in order to get the dark background in the customization palette.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67bff9e4ad11
Use ThreeDShadow rather than ThreeDDarkShadow on checkboxes by default. r=dao,mconley

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/67bff9e4ad11

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 100.0b7 (20220417185951) on Windows 10x64. The Title bar check box is visible inside Customize menu with the Alpenglow theme and Dark OS theme.