1761273 - Multiple dictionaries not stored properly in site preferences

Status: VERIFIED FIXED

(Core :: Spelling checker, defect)

Description

[Dan Minor [:dminor]]

I've noticed in Slack and the WhatsApp web client, if I enable multiple dictionaries in the input box, and then switch to another tab and come back, I'm back to just a single dictionary. There is a problem with storing the user preference for individual sites.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Dan Minor [:dminor] from comment #0)

I've noticed in Slack and the WhatsApp web client, if I enable multiple dictionaries in the input box, and then switch to another tab and come back, I'm back to just a single dictionary. There is a problem with storing the user preference for individual sites.

Firefox doesn't support multiple dictionaries for one input field. Could you clarify what and how you do it?

Comment 2

[Dan Minor [:dminor]]

I just landed support for multiple dictionaries in Bug 1402822, so this is a follow up bug to that, it appears that the site preferences are not stored properly for some sites.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Dan Minor [:dminor] from comment #2)

I just landed support for multiple dictionaries in Bug 1402822, so this is a follow up bug to that, it appears that the site preferences are not stored properly for some sites.

Ah, that's amazing, I didn't know work was happening around that. There must be a ton of duplicate bugs sitting around.

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1761273 - Check for multiple dictionaries when saving site preferences; r=smaug!

We only want to save the site preferences when the user's dictionary
preferences do not match the preferred language for the site. This is always
the case when there is more than one dictionary in use, but the current
code does not handle this case.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e39d2d3f5117
Check for multiple dictionaries when saving site preferences; r=smaug

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e39d2d3f5117

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 100.0a1 (2022-03-28) on Windows 10 x64, macOS 11.6 and on Ubuntu 20.04 x64.

Comment 10

[Alex Finder]

== Change summary for alert #33666 (as of Sun, 27 Mar 2022 02:38:31 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	linkedin LastVisualChange	macosx1015-64-shippable-qr	cold fission webrender	3,291.67 -> 3,220.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33666