Closed Bug 1761368 Opened 2 years ago Closed 2 years ago

Merge all test against the SourceTree into a feature test and reuse the integration test page to cover more source types

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox101 fixed)

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(3 files)

For now we have a couple of tests covering the source tree,
but it would be helpful to merge them into a unique feature test.
In parallel to that, it would also be helpful to leverage more the test page used by integration tests. So that it covers all types of sources.

Blocks: 1747105
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Blocks: 1761975

I'm also improving waitForSourcesInSourceTree to timeout faster and have an helpful error message,
clearly highlight the unexpected or missing sources.

Attachment #9269871 - Attachment description: Bug 1761368 - [detools] Cover name less eval and content script sources in the SourceTree test. → Bug 1761368 - [detools] Cover nameless eval and content script sources in the SourceTree test.
Attachment #9269674 - Attachment description: Bug 1761368 - [detools] Reuse integration test page for the source tree test. → Bug 1761368 - [devtools] Reuse integration test page for the source tree test.
Attachment #9269871 - Attachment description: Bug 1761368 - [detools] Cover nameless eval and content script sources in the SourceTree test. → Bug 1761368 - [devtools] Cover nameless eval and content script sources in the SourceTree test.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c34f0da19bc
[devtools] Merge all tests against the SourceTree into a dedicated feature test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/49ad1260f76d
[devtools] Reuse integration test page for the source tree test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/f478fa1e3df3
[devtools] Cover nameless eval and content script sources in the SourceTree test. r=bomsy

Backed out for causing dt failures on browser_dbg-features-source-tree.js

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js | Uncaught exception in test - at chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:1053 - Error: Failed waitFor(): Results include the source with the query string

Flags: needinfo?(poirot.alex)
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dea0c1268c35
[devtools] Merge all tests against the SourceTree into a dedicated feature test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/ed1e42ba2a21
[devtools] Reuse integration test page for the source tree test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/0810dc3cbfae
[devtools] Cover nameless eval and content script sources in the SourceTree test. r=bomsy
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Regressions: 1762929
Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: