1761368 - Merge all test against the SourceTree into a feature test and reuse the integration test page to cover more source types

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

For now we have a couple of tests covering the source tree,
but it would be helpful to merge them into a unique feature test.
In parallel to that, it would also be helpful to leverage more the test page used by integration tests. So that it covers all types of sources.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1761368 - [devtools] Merge all tests against the SourceTree into a dedicated feature test.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1761368 - [devtools] Reuse integration test page for the source tree test.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1761368 - [devtools] Cover nameless eval and content script sources in the SourceTree test.

I'm also improving waitForSourcesInSourceTree to timeout faster and have an helpful error message,
clearly highlight the unexpected or missing sources.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c34f0da19bc
[devtools] Merge all tests against the SourceTree into a dedicated feature test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/49ad1260f76d
[devtools] Reuse integration test page for the source tree test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/f478fa1e3df3
[devtools] Cover nameless eval and content script sources in the SourceTree test. r=bomsy

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing dt failures on browser_dbg-features-source-tree.js

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js | Uncaught exception in test - at chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:1053 - Error: Failed waitFor(): Results include the source with the query string

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dea0c1268c35
[devtools] Merge all tests against the SourceTree into a dedicated feature test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/ed1e42ba2a21
[devtools] Reuse integration test page for the source tree test. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/0810dc3cbfae
[devtools] Cover nameless eval and content script sources in the SourceTree test. r=bomsy

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dea0c1268c35
https://hg.mozilla.org/mozilla-central/rev/ed1e42ba2a21
https://hg.mozilla.org/mozilla-central/rev/0810dc3cbfae