1761975 - ExtensionContent.jsm appears in the debugger while debugging a page with a web extension content script

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

In the test I'm adding in bug 1761368, I can see that ExtensionContent.jsm appears in the debugger, that, even when devtools.chrome.enabled is false.

Comment 1

[Alexandre Poirot [:ochameau]]

This is easily reproducible when debugging facebook:

• open devtools
• load/reload facebook.com (it is important to load/reload while the debugger is opened, it doesn't reproduce when opening debugger on the page already loaded)

AR: Extension.jsm appears
ER: This should probably not appear as it is an internal of WebExt codebase.

This isn't the whole ExtensionContent.jsm file that appears in the debugger, but only the following bits injected via a sandbox:
https://searchfox.org/mozilla-central/rev/ace2c59e6c56b2dcba25af1aa8903a5e7f9a5857/toolkit/components/extensions/ExtensionContent.jsm#844-888

This is a bit tricky to filter out because the sandbox here is the one used to inject the WebExtension content scripts.
This see these sources thanks to this code:
https://searchfox.org/mozilla-central/rev/ace2c59e6c56b2dcba25af1aa8903a5e7f9a5857/devtools/server/actors/targets/window-global.js#307
We can't change any of that, or the content scripts would all disappear.

We would most likely have to ignore this very particular source...

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1761975 - [devtools] Hide ExtensionContent.jsm when debugging page with WebExt content scripts.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdb40c0a7307
[devtools] Hide ExtensionContent.jsm when debugging page with WebExt content scripts. r=bomsy

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing Xpcshell failures on test_blackboxing-02.js

Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | devtools/server/tests/xpcshell/test_blackboxing-02.js | xpcshell return code: 0
DBG-TEST: :0: error: IndexedDB UnknownErr: ActorsParent.cpp:565

Comment 5

[Alexandre Poirot [:ochameau]]

Sorry I overlooked my try run and missed the xpcshell test failure...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/520d867921ee
[devtools] Hide ExtensionContent.jsm when debugging page with WebExt content scripts. r=bomsy

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/520d867921ee