1761764 - Update in-tree zlib to version 1.2.12

Status: RESOLVED FIXED

(Core :: General, task)

Description

[Ryan VanderMeulen [:RyanVM]]

Version 1.2.12 has these key improvements over 1.2.11:

• Fix a deflate bug when using the Z_FIXED strategy that can result in out-of-bound accesses.
• Fix a deflate bug when the window is full in deflate_stored().
• Speed up CRC-32 computations by a factor of 1.5 to 3.
• Use the hardware CRC-32 instruction on ARMv8 processors.
• Speed up crc32_combine() with powers of x tables.
• Add crc32_combine_gen() and crc32_combine_op() for fast combines.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Bug 1761799 is taking care of the cherry-pick of CVE-2018-25032 so this can just ride the trains.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

No obvious issues on Try:
https://treeherder.mozilla.org/jobs?repo=try&revision=353428efe097b93a46d2453cb41834d010757170

Also, it appears that the gzguts.h change landed previously (https://hg.mozilla.org/mozilla-central/rev/fa1a8a489ee2) for SM WASI builds is no longer necessary. The SM(wasi) job is green without it. Per discussion with Jan, it should be safe to drop.

FWIW, I'm in no hurry to land this given how long it's been since the last release. I already see one upstream issue filed for a possible regression from the new release. While it's nice to see that our CI is green with it, probably still better to let it bake a bit in the wild first.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1761764 - Update in-tree zlib to version 1.2.12.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I went ahead and cherry-picked https://github.com/madler/zlib/commit/ec3df00224d4b396e2ac6586ab5d25f673caa4c2 as that seems like the one post-1.2.12 fix that seems interesting. Other than that, it's been out for about a month now without any other major fallout it seems. Let's move forward with getting this landed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b99aa7bd35f8
Update in-tree zlib to version 1.2.12. r=aosmond

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b99aa7bd35f8