Closed
Bug 1328099
Opened 8 years ago
Closed 8 years ago
Update in-tree zlib to version 1.2.11
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: glennrp+bmo, Assigned: glennrp+bmo)
References
()
Details
Attachments
(1 file, 6 obsolete files)
273.59 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
zlib-1.2.9 was released yesterday, 31 December 2016. We should update the embedded zlib.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
zlib-1.2.9 was found to be buggy and zlib-1.2.10 has been released.
Summary: Update in-tree zlib to version 1.2.9 → Update in-tree zlib to version 1.2.10
Assignee | ||
Comment 2•8 years ago
|
||
Building with zlib-1.2.9 exposed a new bug in libpng-1.6.27 which has been fixed. Marking dependence upon libpng-1.6.28
Depends on: 1328354
Updated•8 years ago
|
URL: zlib.net → http://zlib.net
Assignee | ||
Comment 3•8 years ago
|
||
zlib-1.2.11 has been released to fix a bug in 1.2.10.
Summary: Update in-tree zlib to version 1.2.10 → Update in-tree zlib to version 1.2.11
Assignee | ||
Comment 4•8 years ago
|
||
Assignee | ||
Comment 5•8 years ago
|
||
Added macros to mozzconf.h for new exported symbols in zlib-1.2.11
Attachment #8827305 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
Please "try" the v01 patch, after libpng-1.6.28 lands.
Flags: needinfo?(ryanvm)
Comment 7•8 years ago
|
||
Parsing...Patch id=8827305 desc="v00-1328099-zlib-1.2.11" diff data were discarded: UnicodeDecodeError: 'utf8' codec can't decode byte 0xa7 in position 5774: invalid start byte Patch id=8827311 desc="v01-1328099-zlib-1.2.11" diff data were discarded: UnicodeDecodeError: 'utf8' codec can't decode byte 0xa7 in position 5774: invalid start byte
Flags: needinfo?(ryanvm) → needinfo?(glennrp+bmo)
Assignee | ||
Comment 8•8 years ago
|
||
Removed non-ASCII symbols from ChangeLog Please "try" the v02 patch
Attachment #8827311 -
Attachment is obsolete: true
Flags: needinfo?(glennrp+bmo) → needinfo?(ryanvm)
Comment 9•8 years ago
|
||
I'm still hitting failures trying to apply it :( Parsing...Patch id=8827305 desc="v00-1328099-zlib-1.2.11" diff data were discarded: UnicodeDecodeError: 'utf8' codec can't decode byte 0xa7 in position 5774: invalid start byte Patch id=8827311 desc="v01-1328099-zlib-1.2.11" diff data were discarded: UnicodeDecodeError: 'utf8' codec can't decode byte 0xa7 in position 5774: invalid start byte Patch id=8827510 desc="v02-1328099-zlib-1.2.11" diff data were discarded: UnicodeDecodeError: 'utf8' codec can't decode byte 0xa7 in position 5774: invalid start byte
Flags: needinfo?(ryanvm) → needinfo?(glennrp+bmo)
Assignee | ||
Comment 10•8 years ago
|
||
Attachment #8827510 -
Attachment is obsolete: true
Flags: needinfo?(glennrp+bmo)
Assignee | ||
Comment 11•8 years ago
|
||
Assignee | ||
Comment 12•8 years ago
|
||
Assignee | ||
Comment 13•8 years ago
|
||
Please "try" all 4 parts to try to isolate the charset problem
Flags: needinfo?(ryanvm)
Comment 14•8 years ago
|
||
All 4 apply cleanly, actually. And when I saved v02 of the full patch locally and then tried to import it, that also worked OK. I suspect qimportbz was just getting confused by the older attachments on the bug. Here's a Try push for the full v02 patch, sorry for the confusion: https://treeherder.mozilla.org/#/jobs?repo=try&revision=052dfabc5677fb57db46a839acad7a90fafc8734
Flags: needinfo?(ryanvm)
Assignee | ||
Updated•8 years ago
|
Attachment #8827510 -
Attachment is obsolete: false
Assignee | ||
Updated•8 years ago
|
Attachment #8827547 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8827549 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8827552 -
Attachment is obsolete: true
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8827554 [details] [diff] [review] v03-1328099-part04-zlib-1.2.11.diff Marking v03 parts 1-4 obsolete and restoring v02
Attachment #8827554 -
Attachment is obsolete: true
Assignee | ||
Comment 16•8 years ago
|
||
Comment on attachment 8827510 [details] [diff] [review] v02-1328099-zlib-1.2.11 Try looks green enough.
Attachment #8827510 -
Flags: review?(jmuizelaar)
Updated•8 years ago
|
Attachment #8827510 -
Flags: review?(jmuizelaar) → review+
Comment 17•8 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/749b7caa7b62 Update in-tree zlib to version 1.2.11. r=jrmuizel
Comment 18•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/749b7caa7b62
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•